Chunk reader children cache#8209
Open
myrrc wants to merge 1 commit into
Open
Conversation
myrrc
force-pushed
the
myrrc/layout-children-cache
branch
from
306c6a2 to
5067653
Compare
myrrc
added
action/benchmark
github-actions
Bot
removed
the
action/benchmark
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (2)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.033x ➖ How to read Verdict and Engines
datafusion / vortex-file-compressed (1.033x ➖, 0↑ 2↓)
No file size changes detected. |
Merging this PR will degrade performance by 19.21%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
30.1 µs | 45 µs | -33.15% |
| ❌ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
161.3 µs | 197.6 µs | -18.33% |
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
175.9 µs | 212 µs | -17.03% |
| ❌ | WallTime | cuda/bitpacked_u8/unpack/3bw[100M] |
298.7 µs | 349.2 µs | -14.45% |
| ❌ | Simulation | baseline_lt[16, 65536] |
217.9 µs | 245.4 µs | -11.2% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing myrrc/layout-children-cache (5c2705d) with develop (bd6fc3e)
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.978x ➖, 1↑ 1↓)
datafusion / vortex-compact (0.977x ➖, 1↑ 0↓)
datafusion / parquet (0.964x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (0.971x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.972x ➖, 0↑ 0↓)
duckdb / parquet (0.973x ➖, 0↑ 0↓)
File Size Changes (1 files changed, +0.0% overall, 1↑ 0↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.024x ➖, 0↑ 0↓)
datafusion / vortex-compact (1.023x ➖, 0↑ 2↓)
datafusion / parquet (0.998x ➖, 0↑ 1↓)
datafusion / arrow (1.026x ➖, 1↑ 2↓)
duckdb / vortex-file-compressed (1.020x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.009x ➖, 0↑ 0↓)
duckdb / parquet (1.012x ➖, 0↑ 1↓)
duckdb / duckdb (1.010x ➖, 0↑ 0↓)
File Size Changes (10 files changed, -0.1% overall, 4↑ 6↓)
Totals:
|
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.989x ➖, 2↑ 0↓)
datafusion / vortex-compact (1.001x ➖, 3↑ 1↓)
datafusion / parquet (1.006x ➖, 1↑ 2↓)
duckdb / vortex-file-compressed (0.998x ➖, 2↑ 1↓)
duckdb / vortex-compact (1.006x ➖, 0↑ 0↓)
duckdb / parquet (0.999x ➖, 0↑ 1↓)
duckdb / duckdb (0.994x ➖, 3↑ 0↓)
File Size Changes (7 files changed, -0.0% overall, 2↑ 5↓)
Totals:
|
AdamGS
reviewed
Jun 2, 2026
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.908x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.908x ➖, 1↑ 1↓)
datafusion / parquet (0.956x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (0.972x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.955x ➖, 0↑ 0↓)
duckdb / parquet (0.957x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) How to read Verdict and Engines
duckdb / vortex-file-compressed (0.995x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.000x ➖, 0↑ 0↓)
duckdb / parquet (0.995x ➖, 0↑ 0↓)
File Size Changes (1 files changed, +0.0% overall, 1↑ 0↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.012x ➖, 0↑ 0↓)
datafusion / vortex-compact (1.017x ➖, 0↑ 0↓)
datafusion / parquet (1.012x ➖, 0↑ 0↓)
datafusion / arrow (0.985x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (1.012x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.003x ➖, 0↑ 0↓)
duckdb / parquet (0.992x ➖, 1↑ 0↓)
duckdb / duckdb (1.000x ➖, 0↑ 0↓)
File Size Changes (27 files changed, -0.0% overall, 13↑ 14↓)
Totals:
|
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.024x ➖, 2↑ 5↓)
datafusion / parquet (0.974x ➖, 2↑ 0↓)
duckdb / vortex-file-compressed (1.014x ➖, 4↑ 2↓)
duckdb / parquet (1.032x ➖, 0↑ 0↓)
duckdb / duckdb (1.084x ➖, 0↑ 15↓)
File Size Changes (107 files changed, -0.0% overall, 49↑ 58↓)
Totals:
|
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.890x ➖, 3↑ 0↓)
datafusion / vortex-compact (0.829x ➖, 7↑ 2↓)
datafusion / parquet (0.952x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (0.939x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.961x ➖, 0↑ 0↓)
duckdb / parquet (0.931x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: Appian on NVMEVerdict: No clear signal (low confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (1.007x ➖, 0↑ 0↓)
datafusion / parquet (1.006x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.992x ➖, 0↑ 0↓)
duckdb / parquet (0.991x ➖, 0↑ 0↓)
duckdb / duckdb (0.995x ➖, 0↑ 0↓)
File Size Changes (4 files changed, -0.0% overall, 2↑ 2↓)
Totals:
|
Contributor
Benchmarks: Random AccessVortex (geomean): 1.017x ➖ How to read Verdict and Engines
unknown / unknown (1.063x ➖, 2↑ 6↓)
|
Contributor
Benchmarks: CompressionVortex (geomean): 0.992x ➖ How to read Verdict and Engines
unknown / unknown (1.016x ➖, 3↑ 10↓)
|
Contributor
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) How to read Verdict and Engines
datafusion / vortex-file-compressed (0.817x ➖, 2↑ 0↓)
datafusion / vortex-compact (0.832x ➖, 4↑ 0↓)
datafusion / parquet (0.890x ➖, 2↑ 1↓)
duckdb / vortex-file-compressed (0.956x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.044x ➖, 0↑ 0↓)
duckdb / parquet (0.885x ➖, 0↑ 0↓)
|
Contributor
|
What is the scope of the cache? |
myrrc
changed the title
Contributor
Author
|
Chunk reader lifetime |
myrrc
force-pushed
the
myrrc/layout-children-cache
branch
from
5067653 to
a934f10
Compare
github-actions
Bot
removed
the
action/benchmark
myrrc
force-pushed
the
myrrc/layout-children-cache
branch
from
a934f10 to
5c2705d
Compare
github-actions
Bot
removed
the
action/benchmark
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't reinitialize ChunkedReader children with their own caches each time.