feat: arrow device array list view export#8219
Open
0ax1 wants to merge 10 commits into
Open
Conversation
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Merging this PR will improve performance by 18.46%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[128] |
246.1 ns | 275.3 ns | -10.6% |
| ⚡ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
45.4 µs | 30.5 µs | +49.13% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
197.7 µs | 161.5 µs | +22.43% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
212.3 µs | 176 µs | +20.64% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ad/cudf-list-export (d9d49ad) with develop (66335d4)
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
cuDF's from_arrow_device_column has no Arrow FixedSizeList -> cudf type mapping, so including a fixed_lists column in the exported struct made the harness fail with "Unsupported type_id conversion to cudf". Vortex still exports FixedSizeList correctly (covered by the test_export_fixed_size_list unit test in vortex-cuda); the column simply cannot round-trip through cuDF's device-array import. Keep the lists column, which cuDF supports. Signed-off-by: Alexander Droste <alexander.droste@protonmail.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
connortsui20
reviewed
Jun 2, 2026
robert3005
reviewed
Jun 2, 2026
robert3005
reviewed
Jun 2, 2026
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Signed-off-by: Alexander Droste <alexander.droste@protonmail.com>
Contributor
Author
|
depends on a new cudf harness release: vortex-data/cudf-test-harness#6 |
robert3005
reviewed
Jun 3, 2026
robert3005
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds CUDA Arrow Device export for Vortex
ListViewArrayby exporting it as standard ArrowListfor cuDF.i32Arrow offsetsListViewArray→ListArrayrebuild when GPU export cannot handle the shape