Mask bool iterator#8258
Conversation
Signed-off-by: Onur Satici <onur@spiraldb.com>
Merging this PR will degrade performance by 11.08%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
269.9 µs | 305.3 µs | -11.57% |
| ❌ | Simulation | bitwise_not_vortex_buffer_mut[128] |
246.1 ns | 275.3 ns | -10.6% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing os/mask-iter (44cd55a) with develop (583b003)
|
This looks like a very slow way to iterate. We should use a u64 packed validity iterator. I am not sure if we should merge then and then that. But each call site will change |
|
BitIterator works on u64 words, not sure what do you mean @joseph-isaacs ? |
Summary
Bool iterator to mask to be used by code that gets the bool values from a mask in a loop