Properly do close code and reason#4
Merged
Conversation
Author
|
@mbonneau ping |
mbonneau
reviewed
Dec 5, 2019
Member
|
@CharlotteDunois This looks good - thanks for the PR, I just had the one comment on the close emit above. Let me know your thoughts and we can work to get this merged. |
ghost
requested a review
from
Member
|
@CharlotteDunois Sorry about the delay in merging, ran into a small issue with the autobahn test suite when I was trying to test this. |
mbonneau
approved these changes
Dec 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly parses the close code and reason from the close frame and removes the close exception (close codes >= 2000 are by definition NOT errors). This is #3, but with just the close code update. Fixes #2.