Enhancement/map2png objshow#28
Merged
Merged
Conversation
voshch
requested changes
Mar 19, 2026
| # get the corners for entity | ||
|
|
||
| # if dimension is given as extra property, use it | ||
| _width = entity.asdict(expand_extra=True).get("width") |
Owner
There was a problem hiding this comment.
It's unclear to me how the width/heights would be provided in practice. Picture in the PNG seems to have all default widths.
Are there any current use cases where width/height is explicitly passed?
| import shapely | ||
| import math | ||
|
|
||
| staticObjects: list[tuple[str, shapely.Polygon]] = [] |
Owner
There was a problem hiding this comment.
Drawing objects should be entirely optional. Default behavior of touch_world script must remain unchanged.
Author
|
fixed it following suggestions |
Author
voshch
added a commit
that referenced
this pull request
Mar 24, 2026
(cherry picked from commit 9785cf9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
added static object bounding boxes to .png export from Map
Changes
Wallclassgenerate_png:changed so that it will take optional arguments for tuple of object name and shapely polygon to draw grey rect on entity position
WorldDescriptionclassrendermodified to work with the new generate_png method
rendered image example
exported from AIrchitect app
