Skip to content
This repository was archived by the owner on Sep 27, 2021. It is now read-only.

re: added lagrange multiplier based optimization for pressure and die…#199

Closed
moradza wants to merge 1 commit intovotca:masterfrom
moradza:master
Closed

re: added lagrange multiplier based optimization for pressure and die…#199
moradza wants to merge 1 commit intovotca:masterfrom
moradza:master

Conversation

@moradza
Copy link

@moradza moradza commented Dec 14, 2016

re: added lagrange multiplier based optimization for pressure and dielectric permittivity

Copy link
Member

@junghans junghans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have seemed to use some older version of the source, please merge your changes with latest master first!

* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
* Author: sikandar
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep copyright!

* See the License for the specific language governing permissions and
* limitations under the License.
*
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep copyright?

* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

die "${0##*/}: Pressure was nan, check your simulation (this usually means system has blow up -> use pre simulation)"

echo "Pressure=${p_now}" > "$1"
echo "${p_now}" > "$1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

#! /bin/bash
#
# Copyright 2009-2016 The VOTCA Development Team (http://www.votca.org)
# Copyright 2009-2011 The VOTCA Development Team (http://www.votca.org)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo!

#support for older mdp file, cutoff-scheme = Verlet is default for Gromacs 5.0, but does not work with tabulated interactions
#XXX is returned if cutoff-scheme is not in mdp file
if [[ $(get_simulation_setting cutoff-scheme XXX) = XXX ]]; then
if [[ $(critical ${grompp[@]} -h 2>&1) = *"VERSION 5."[01]* && $(get_simulation_setting cutoff-scheme XXX) = XXX ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

mdrun_opts+=" -tableb${tables}"
fi
fi

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

else
msg --color blue --to-stderr "Appending -nsteps ${CSG_MDRUN_STEPS} to mdrun options"
mdrun_opts+=" -nsteps $CSG_MDRUN_STEPS"
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@@ -1,5 +1,91 @@
#! /bin/bash
#
# Copyright 2009-2015 The VOTCA Development Team (http://www.votca.org)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2016?

if [[ ${CSG_RUNTEST} ]] && csg_calc "$first_frame" ">" "0"; then
msg --color blue --to-stderr "Automatically setting first_frame to 0, because CSG_RUNTEST was set"
first_frame=0
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@junghans
Copy link
Member

junghans commented Dec 14, 2016

To make tests pass:

  • add a default for cg.inverse.permittivity in csg_defaults.xml.in otherwise
  • fix gcc warnings
  • add a test csg-tutorials

@junghans junghans self-assigned this Dec 14, 2016
@junghans junghans added this to the V1.5 milestone Dec 14, 2016
@moradza
Copy link
Author

moradza commented Dec 15, 2016 via email

@junghans
Copy link
Member

junghans commented Mar 2, 2017

ping @moradza / @symashayak

@junghans
Copy link
Member

Closed due to inactivity!

@junghans junghans closed this Aug 24, 2017
@junghans
Copy link
Member

junghans commented Jun 9, 2018

The code is here: https://github.com/moradza/VOTCA_CRE

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants