Skip to content
This repository was archived by the owner on Sep 27, 2021. It is now read-only.

Allow to change extrapolation function for lammps#203

Merged
junghans merged 2 commits intomasterfrom
extrapolate
Apr 6, 2017
Merged

Allow to change extrapolation function for lammps#203
junghans merged 2 commits intomasterfrom
extrapolate

Conversation

@junghans
Copy link
Member

@junghans junghans requested a review from jdmoore2004 March 12, 2017 15:22
@junghans junghans changed the title Allow to change extrapolation function forlammps Allow to change extrapolation function for lammps Mar 12, 2017
Copy link
Contributor

@jdmoore2004 jdmoore2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I haven't tested it, because I wasn't sure how to download the fork, but I will look into it tomorrow. This is a nice option to have.

@junghans
Copy link
Member Author

You can do git fetch origin pull/203/head && git checkout FETCH_HEAD.

@jdmoore2004
Copy link
Contributor

I'm not sure if I checked it out wrong, but I think I have the correct files. I am getting

###############################################################################################################################

ERROR:

Unknown option '--lfct=sasha'

For details see the logfile /home/XXXX/inverse.log

###############################################################################################################################

Setting

  <lammps>
    <table>table_b1.pot</table>
    <table_begin>2.0</table_begin>
    <table_end>8.0</table_end>
    <table_left_extrapolation>sasha</table_left_extrapolation>
    <table_right_extrapolation>sasha</table_right_extrapolation>
  </lammps>

Thanks.

@junghans
Copy link
Member Author

Got it! Shell option parsing only works for --lfct sasha not --lfct=sasha. Give it another try.

@jdmoore2004
Copy link
Contributor

Line 61 of potential_extrapolate.sh has an extra $

Change

is_part "${$2}" "${fct_types}" || die "${0##*/}: given function type ($2) is not in the list of functions (${fct_types})"

to

is_part "${2}" "${fct_types}" || die "${0##*/}: given function type ($2) is not in the list of functions (${fct_types})"

Seems to work great otherwise. Tested it on bonds for linear, quadratic, exponential and sasha left and right.

@junghans
Copy link
Member Author

Typo fixed!

@junghans junghans merged commit b66d246 into master Apr 6, 2017
@junghans junghans deleted the extrapolate branch April 6, 2017 18:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants