Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #600
I don't fully understand my own fix! But from what I can gather:
It's not necessary to tack on
access_tokenas a query parameter to the API endpoints (I'm not sure if that's the underlying cause)Subtle change to the
PrepareTokensAndClientin the provider -opts...was not being passed in. I have a feeling this was the true cause, that being it wasn't passing the...oauth2.AuthCodeOptionto that function and hence the 400 (the auth code was missing?) ? Maybe?Anyway, with these changes, it's working for me now. I am using a simple config that is just 'whitelisting' my own Github username - didn't test teamWhiteList.
Note:
./do.sh testis failing but due to a separate test to due withTestValidateRequestHandlerPerf. I suspect it's a known, existing issue.