fix(openclaw): repackage plugin for the 2026.6 loader dialect#339
Merged
Conversation
the old openclaw.plugin.json spoke a manifest dialect current openclaw no longer parses: installs of the linked repo failed before load (the loader hard-requires id + configSchema, routes any dir containing an openclaw.plugin.json away from the bundle path, and needs a package.json openclaw.extensions pointer to find the entry module). every old-dialect field the manifest relied on — mcpServers, contracts, family, shared_deps, openclaw.* — is silently ignored by the current parser. rewrite the packaging for the current contract, verified against a real openclaw 2026.6.11 install: * openclaw.plugin.json: id + json-schema configSchema + kind: context-engine + version (synced with pyproject) + skills as SKILL.md directories under adapters/openclaw/skills/ (mirrored from the claude-code commands; a sync test keeps them identical). the kb.* mcp server moves to deployment config (openclaw mcp add). * package.json (new, loader-facing only): openclaw.extensions entry pointer + openclaw.compat.pluginApi floor. * engine id renamed vouch-context -> vouch to equal the plugin id: the installer auto-binds plugins.slots.contextEngine to the plugin id while resolveContextEngine looks the slot value up by engine id, so distinct ids quarantined the engine and silently fell back to openclaw's legacy engine. * vouch openclaw-rpc: json-serialize datetimes in wire payloads. contextPack.generated_at crashed json.dumps on every assemble that found a kb — found by running a live agent turn against the linked plugin, where openclaw quarantined the engine for the process. * tests: manifest sync tests rewritten for the new dialect (id alignment, three-way version sync, publishable skill dirs, dead dialect fields rejected); new tier-2 e2e (tests/test_openclaw_plugin_load_real.py, skipped without the openclaw cli) links the repo into an isolated profile and asserts import, engine registration, slot auto-bind, skill publication, and a clean plugins doctor; new stdio round-trip regression test for the datetime fix. verified live: plugins install --link of this repo, inspect --runtime (imported, loaded, contextEngineIds ["vouch"]), four skills ready, plugins doctor clean, and a full embedded agent turn where assemble() ran against a real kb with zero context-engine quarantines.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
# Conflicts: # CHANGELOG.md # openclaw.plugin.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the old openclaw.plugin.json spoke a manifest dialect current openclaw no longer parses: installs of the linked repo failed before load (the loader hard-requires id + configSchema, routes any dir containing an openclaw.plugin.json away from the bundle path, and needs a package.json openclaw.extensions pointer to find the entry module). every old-dialect field the manifest relied on — mcpServers, contracts, family, shared_deps, openclaw.* — is silently ignored by the current parser.
rewrite the packaging for the current contract, verified against a real openclaw 2026.6.11 install:
verified live: plugins install --link of this repo, inspect --runtime (imported, loaded, contextEngineIds ["vouch"]), four skills ready, plugins doctor clean, and a full embedded agent turn where assemble() ran against a real kb with zero context-engine quarantines.
What changed
Why
What might break
VEP
Tests
make checkpasses locally (lint + mypy + pytest)CHANGELOG.mdupdated under## [Unreleased]