Skip to content

Conversation

@marcusdots
Copy link
Contributor

In my opinion the requirement of the linter is satisfied. The code is idempotent. It is the parameter passing using the splat operator that enables idempotency. Puppet lint is a static validator that does not see the runtime fullfilment. It is ok to disable the check

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

… linter is satisfied. The code is idempotent. It is the parameter passing using the splat operator that enables idempotency. Puppet lint is a static validator that does not see the runtime fullfilment. It is ok to disable the check
@tuxmea
Copy link
Member

tuxmea commented Dec 4, 2025

Errors coming from installing gitlab-ce:

STDERR: sysctl: permission denied on key "kernel.pid_max"
  sysctl: permission denied on key "fs.protected_fifos"
  sysctl: permission denied on key "fs.protected_hardlinks"
  sysctl: permission denied on key "fs.protected_regular"
  sysctl: permission denied on key "fs.protected_symlinks"

@tuxmea
Copy link
Member

tuxmea commented Dec 4, 2025

In this case the idempotency is coming from a hash which is used on the exec resource using splat operator.
The lint check can not evalute this.

Therefore it is OK to disable the idempotency check.

due to some $magic between podman and sysctl, we will switch to docker for the pipeline to pass.
@marcusdots marcusdots merged commit cbe14ed into voxpupuli:modulesync Dec 4, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants