Fix Python 3.14 DeprecationWarning caused by implicit ctypes layout when using _pack_ = 1.#112
Merged
Merged
Conversation
Owner
|
Thank you for a nice bug report.
|
Implicit behavior of _pack_ is deprecated in Python 3.14. Eliminate warning by explicitly setting _layout_ attribute to "ms".
DedUndead
force-pushed
the
pack-deprecation
branch
from
5a85b24 to
5dc02e5
Compare
Contributor
Author
|
@vpelletier Thank you for prompt response. Good catch, I amended per your request and updated pull request description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix addresses issue #111.
This change adds
_layout_ = "ms"tolibusb_control_setupandnewStructstructures to explicitly preserve the existing MSVC-compatible structure layout and avoid the warning becoming an error in future Python versions.Without this fix, importing usb1 on Python 3.14 with warnings treated as errors fails with
DeprecationWarning.Tested with:
python3.14 -W error::DeprecationWarning -c "import usb1"