fix: DudesCab detection on Linux#46
Merged
jsm174 merged 2 commits intovpinball:masterfrom Apr 12, 2026
Merged
Conversation
Fix wchar_t to string conversion for product_string and serial_number which produced garbled strings on non-Windows platforms. Also match DudesCab by HID interface number on Linux since hidapi-hidraw returns the USB-level product string for all interfaces instead of per-interface HID string descriptors.
Collaborator
|
Thank you for this! I added MacOS as well because its probably going to need the same check. |
Contributor
Author
|
Yeah, that's a good catch. Sounds like there is at least one person using a Dude's Cab board with a Mac so hopefully they can validate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix wchar_t to string conversion for product_string and serial_number which produced garbled strings on non-Windows platforms. Also match DudesCab by HID interface number on Linux since hidapi-hidraw returns the USB-level product string for all interfaces instead of per-interface HID string descriptors.