Skip to content

Bugfix: Issues with table access on the ClickHouse driver#1176

Merged
vrana merged 1 commit intovrana:masterfrom
Marcus-Nightingale:clickhouse-driver-fix
Oct 27, 2025
Merged

Bugfix: Issues with table access on the ClickHouse driver#1176
vrana merged 1 commit intovrana:masterfrom
Marcus-Nightingale:clickhouse-driver-fix

Conversation

@Marcus-Nightingale
Copy link
Contributor

Bugfix: table_status($name) in the ClickHouse driver ignored the $name argument and always returned all tables.

This caused Adminer’s UI (e.g. breadcrumbs, links and title) to show the wrong table as selected.

Fixed by applying the $name filter in the query so only the requested table is returned.

@Marcus-Nightingale
Copy link
Contributor Author

@vrana i assume i actually need to follow the docs here to get the CI build to pass?

@magnusvin
Copy link

You can check the 3 last commits in #1183 on how i fixed. If it is the correct way i am unsure....

@Marcus-Nightingale Marcus-Nightingale changed the title Update clickhouse.php Bugfix to Clickhouse driver which prevents table access Oct 15, 2025
@Marcus-Nightingale Marcus-Nightingale changed the title Bugfix to Clickhouse driver which prevents table access Bugfix: Issues with table access on the ClickHouse driver Oct 15, 2025
@Marcus-Nightingale
Copy link
Contributor Author

You can check the 3 last commits in #1183 on how i fixed. If it is the correct way i am unsure....

I had a look and there was a few other violations on the phpcs stuff for me. I have created another branch to bring that upto date but we will need @vrana to confirm i think

@vrana vrana merged commit f4f7568 into vrana:master Oct 27, 2025
1 check failed
vrana pushed a commit that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants