Adds stub methods for AvatarScaling#99
Merged
momo-the-monster merged 4 commits intomainfrom Aug 17, 2023
Merged
Conversation
momo-the-monster
force-pushed
the
98-avatar-scaling-methods-missing-from-clientsim
branch
from
ce811a5 to
7c2be69
Compare
Faxmashine
requested changes
Aug 2, 2023
Contributor
Faxmashine
left a comment
Faxmashine
left a comment
There was a problem hiding this comment.
Nice, looks like the errors have been resolved.
I made a few suggestions.
The SDK was giving me some trouble:
Packages\com.vrchat.clientsim\Runtime\System\ClientSimMain.cs(484,26): error CS0117: 'VRCPlayerApi' does not contain a definition for '_GetCurrentLanguage'
I had to remove these two lines in ClientSimMain.cs. It's probably unrelated.
//VRCPlayerApi._GetCurrentLanguage += ClientSimPlayerManager.GetCurrentLanguage;
//VRCPlayerApi._GetAvailableLanguages += ClientSimPlayerManager.GetAvailableLanguages;
```
Packages/com.vrchat.ClientSim/Runtime/System/ClientSimPlayerManager.cs
Outdated
Show resolved
Hide resolved
Packages/com.vrchat.ClientSim/Runtime/System/ClientSimPlayerManager.cs
Outdated
Show resolved
Hide resolved
…nager.cs Co-authored-by: Fax <117199600+Faxmashine@users.noreply.github.com>
…nager.cs Co-authored-by: Fax <117199600+Faxmashine@users.noreply.github.com>
Faxmashine
approved these changes
Aug 2, 2023
Contributor
Faxmashine
left a comment
Faxmashine
left a comment
There was a problem hiding this comment.
If the errors I was getting are related to 3.2.3, then this is good to go.
Collaborator
Author
|
The errors were caused because the |
momo-the-monster
deleted the
98-avatar-scaling-methods-missing-from-clientsim
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes NREs in SDK 3.2.2. Would be nice to actually Set and Get the values so Creators can test their logic in ClientSim, but this minimal implementation at least fixes the SDK so it doesn't show scary errors when you enter play mode.