Skip to content

Remove use of unnamed Inline Requests and Responses#102

Merged
Foorack merged 8 commits intomainfrom
inline-object
Oct 23, 2021
Merged

Remove use of unnamed Inline Requests and Responses#102
Foorack merged 8 commits intomainfrom
inline-object

Conversation

@Foorack
Copy link
Copy Markdown
Member

@Foorack Foorack commented Oct 23, 2021

Fixes #97

@Foorack Foorack added Type: Maintenance This will neither fix incorrectness nor add value, but is rather a project cleanup Priority: High High priority, this ideally needs to be fixed first labels Oct 23, 2021
@Foorack Foorack self-assigned this Oct 23, 2021
@Foorack
Copy link
Copy Markdown
Member Author

Foorack commented Oct 23, 2021 •
edited
Loading

@Rexios80 This removes all "InlineObject11" and "InlineResponse2004" objects, and gives them real names. Please try compile with https://b6b36520.vrchatapi-specification.pages.dev/openapi.yaml and see if/how much this breaks anything with your Dart library.

This is scheduled for 1.5.0, which will be a bigger/slightly breaking release.

@Foorack Foorack requested a review from Rexios80 October 23, 2021 15:06
@Rexios80
Copy link
Copy Markdown
Collaborator

Rexios80 commented Oct 23, 2021

It generated fine

@Foorack
Copy link
Copy Markdown
Member Author

Foorack commented Oct 23, 2021

It generated fine

OK, thanks!

@Foorack Foorack merged commit a274612 into main Oct 23, 2021
@Foorack Foorack deleted the inline-object branch October 23, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Rexios80 Rexios80 Awaiting requested review from Rexios80

Assignees

@Foorack Foorack

Labels

Priority: High High priority, this ideally needs to be fixed first Type: Maintenance This will neither fix incorrectness nor add value, but is rather a project cleanup

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove all unnamed objects and responses

2 participants

@Foorack @Rexios80