Merged
Conversation
Member
Author
|
This should cover the base implementation of uploading, managing, and deleting files. Further documentation, especially in areas to how This will be revisited once automatic library generation has been further researched, and the various API calls can be automated. The FileAPI is particularly laborious to test manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6
The comment on the Docsify/Markdown version was right, the FileAPI and especially File upload is indeed wonky. Sometimes requests just times out with no response. As the SDK is the only part uploading files through these endpoints there is also incredibly limited information/documentation on any of these. The Gallery/Icon upload on the website uses completely different endpoints.
This FileAPI documentation ideally needs to be improved even further in future updates. It would be good to add more instructions and an outline of the whole timeline from start to finish with all the required steps to upload a file with delta and signature. More testing is also needed to see if different edge cases are covered (e.g. simple vs multipart upload).