Skip to content

Run OpenAPI Bundler as GitHub CI task#18

Merged
Foorack merged 2 commits intovrchatapi:masterfrom
Foorack:bundler
Jul 12, 2021
Merged

Run OpenAPI Bundler as GitHub CI task#18
Foorack merged 2 commits intovrchatapi:masterfrom
Foorack:bundler

Conversation

@Foorack
Copy link
Copy Markdown
Member

@Foorack Foorack commented Jul 12, 2021

This packages the openapi.yml file as a bundled spec and makes it available as artifact.

In the future even linting and validation could ideally be added as CI jobs.

@Foorack Foorack added Type: Maintenance This will neither fix incorrectness nor add value, but is rather a project cleanup Priority: Low Low priority, this has least priority to be fixed Status: Review Needed Awaiting someone to Review this PR labels Jul 12, 2021
@Foorack Foorack requested a review from ariesclark July 12, 2021 21:28
@Foorack Foorack self-assigned this Jul 12, 2021
@Foorack
Copy link
Copy Markdown
Member Author

Foorack commented Jul 12, 2021

AFAIK this will not be executed as GitHub will only run the workflow file on the master branch. This is to prevent someone from committing a workflow that prints secrets or mines Bitcoin.

@Foorack Foorack merged commit 13c3f31 into vrchatapi:master Jul 12, 2021
@Foorack Foorack deleted the bundler branch July 12, 2021 22:07
@Foorack Foorack added Status: Completed We did it! Ready to merge! and removed Status: Review Needed Awaiting someone to Review this PR labels Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Low Low priority, this has least priority to be fixed Status: Completed We did it! Ready to merge! Type: Maintenance This will neither fix incorrectness nor add value, but is rather a project cleanup

Development

Successfully merging this pull request may close these issues.

2 participants