Skip to content

Auth endpoints only require basic auth#21

Merged
Foorack merged 2 commits intovrchatapi:masterfrom
Rexios80:feature/auth-security-fixes
Jul 16, 2021
Merged

Auth endpoints only require basic auth#21
Foorack merged 2 commits intovrchatapi:masterfrom
Rexios80:feature/auth-security-fixes

Conversation

@Rexios80
Copy link
Copy Markdown
Collaborator

No description provided.

@ariesclark ariesclark requested a review from Foorack July 16, 2021 04:35
@Foorack Foorack added Priority: Medium Normal priority Status: Review Needed Awaiting someone to Review this PR Type: Bug There is a **factual incorrectness** in the spec labels Jul 16, 2021
Copy link
Copy Markdown
Member

@Foorack Foorack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove apiKey from /otp/, I've tested and it also doesn't need 2FA.

Comment thread openapi.yaml
@Foorack Foorack added Status: Revision Needed It is a good first step, but something/more needs to be done/fixed before this can be merged and removed Status: Review Needed Awaiting someone to Review this PR labels Jul 16, 2021
@Rexios80 Rexios80 requested a review from Foorack July 16, 2021 15:42
Copy link
Copy Markdown
Member

@Foorack Foorack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, good job! Thanks!

@Foorack Foorack added Status: Completed We did it! Ready to merge! and removed Status: Revision Needed It is a good first step, but something/more needs to be done/fixed before this can be merged labels Jul 16, 2021
@Foorack Foorack merged commit e5d757f into vrchatapi:master Jul 16, 2021
@Rexios80 Rexios80 deleted the feature/auth-security-fixes branch August 4, 2021 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Medium Normal priority Status: Completed We did it! Ready to merge! Type: Bug There is a **factual incorrectness** in the spec

Development

Successfully merging this pull request may close these issues.

2 participants