Conversation
Foorack
added
Type: Maintenance
Foorack
added
Status: Completed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no point in having a DateTime model simply wrapping around a string with format
date-time. The Model contained requirements for how the timestamp should look like, but that is already hard-defined by the OpenAPI specification:date– full-date notation as defined by RFC 3339, section 5.6, for example, 2017-07-21date-time– the date-time notation as defined by RFC 3339, section 5.6, for example, 2017-07-21T17:32:28ZCC @Rexios80 This has a slight chance of affecting your code generation, but ideally it shouldn't.