Skip to content

Document PUT /groups/:groupId/representation endpoint#470

Merged
ariesclark merged 1 commit intovrchatapi:mainfrom
Raphiiko:put-group-representation
May 25, 2025
Merged

Document PUT /groups/:groupId/representation endpoint#470
ariesclark merged 1 commit intovrchatapi:mainfrom
Raphiiko:put-group-representation

Conversation

@Raphiiko
Copy link
Copy Markdown
Contributor

This endpoint seemed to be missing from the docs, so I've tried to add it.

@Raphiiko Raphiiko changed the title Documents PUT /groups/:groupId/representation endpoint Document PUT /groups/:groupId/representation endpoint May 24, 2025
@ariesclark
Copy link
Copy Markdown
Member

ariesclark commented May 24, 2025

Thanks for your contribution, can you add the related test to vrchatapi/specification-test?

@Raphiiko
Copy link
Copy Markdown
Contributor Author

I absolutely can. I've written some tests, but I'm having some trouble getting them to run locally.

Here are the steps I attempted to get the current tests to run (without my new tests added):
(On WSL with Ubuntu 24.04 LTS, Node v20.19.2, pnpm 8.15.9, to match the runner environment)

  • Cloned the specification-test repository (and installed the dependencies with pnpm)
  • Provided a .env file with the the following env vars with the account details of my (non-vrc+) test account: VRCHAT_EMAIL, VRCHAT_USERNAME, VRCHAT_PASSWORD, VRCHAT_TOTP_SECRET, VRCHAT_FRIEND_ID
  • Provided the openapi.yaml in the repository root, generated by running npm run bundle on this PR.
  • Ran npm run test

You can find the output here: output.txt

Do you have any hints on what I could try to get this working?

@ariesclark
Copy link
Copy Markdown
Member

ariesclark commented May 24, 2025

It looks like a successful run to me, there's a lot of verbosity, what's the output of data/requests/readme.md? You can also run specific tests by running pnpm test [<pattern>...].

I'd expect some group tests to fail without VRC+ & everything-else is unrelated problems like VRChat randomly introducing debugflag to responses, or the forever-wrong infopush/config endpoints.

@Raphiiko
Copy link
Copy Markdown
Contributor Author

Ahh I see now, alright. I've provided the updated tests in vrchatapi/specification-test#23.

@ariesclark ariesclark enabled auto-merge (squash) May 25, 2025 17:33
@ariesclark ariesclark merged commit de3d3b1 into vrchatapi:main May 25, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants