Skip to content

fix(favorite): type is not read-only, it is submitted during addFavorite#50

Merged
Foorack merged 1 commit intomainfrom
favorite-add-fix
Aug 29, 2021
Merged

fix(favorite): type is not read-only, it is submitted during addFavorite#50
Foorack merged 1 commit intomainfrom
favorite-add-fix

Conversation

@Foorack
Copy link
Copy Markdown
Member

@Foorack Foorack commented Aug 29, 2021

Setting type as read-only caused it to not show up as as part of the request body for addFavorite. Thanks for Devin_Lucashu for helping in finding this.

@Foorack Foorack added Type: Bug There is a **factual incorrectness** in the spec Priority: High High priority, this ideally needs to be fixed first labels Aug 29, 2021
@Foorack Foorack self-assigned this Aug 29, 2021
@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d7ad712
Status: ✅  Deploy successful!
Preview URL: https://feb77b3a.vrchatapi-specification.pages.dev

View logs

@Foorack Foorack merged commit 35ea454 into main Aug 29, 2021
@Foorack Foorack deleted the favorite-add-fix branch August 29, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: High High priority, this ideally needs to be fixed first Type: Bug There is a **factual incorrectness** in the spec

Development

Successfully merging this pull request may close these issues.

1 participant