Skip to content

Fix divider color #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bendera merged 4 commits into from
Nov 29, 2024
Merged

Fix divider color #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d8d32f5
Make divider color visible in all themes
bendera Nov 29, 2024
563ed91
Update changelog
bendera Nov 29, 2024
9387528
Fix header levels in changelog
bendera Nov 29, 2024
8d29fea
Upgrade Playground
bendera Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,20 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

## [Unreleased]

### Fixed

- **Divider**: Make component color visible in all themes.

## [1.9.0] - 2024-11-26

## Added
### Added

- Add support for two-way binding with form controls in Vue.
- **ContextMenu**: Added `preventClose` property.

## Fixed
### Fixed

- **ContextMenu**: `show` attribute was not synchronized correctly.

Expand Down
31 changes: 31 additions & 0 deletions dev/vscode-divider/basic-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<!doctype html>
<html lang="en">

<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>VSCode Elements</title>
<link rel="stylesheet" href="/node_modules/@vscode/codicons/dist/codicon.css" id="vscode-codicon-stylesheet">
<script type="module" src="/node_modules/@vscode-elements/webview-playground/dist/index.js"></script>
<script type="module" src="/dist/vscode-divider/index.js"></script>
<script>
const logEvents = (selector, eventType) => {
document.querySelector(selector).addEventListener(eventType, (ev) => {
console.log(ev);
});
};
</script>
</head>

<body>
<h1>Divider</h1>
<main>
<vscode-demo>
<p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Quisque quis ligula id magna vulputate mollis vel eu massa. Nam cursus velit in egestas viverra. Pellentesque euismod porta elit, sed imperdiet lectus ultrices vel. Aenean eleifend interdum tincidunt. Fusce interdum leo vitae ante egestas imperdiet nec vel quam. Integer dictum eget tortor id porta. Ut faucibus, lacus a interdum molestie, neque urna luctus purus, quis vulputate est est sit amet lectus. Sed eros mauris, lacinia sed lacinia in, fringilla in neque. Nulla eu auctor tortor.</p>
<vscode-divider></vscode-divider>
<p>Maecenas non velit velit. Fusce tempor risus a gravida volutpat. Class aptent taciti sociosqu ad litora torquent per conubia nostra, per inceptos himenaeos. Etiam tincidunt condimentum orci, sit amet consequat odio semper non. Ut a pharetra orci. Ut et aliquet quam. Phasellus a ullamcorper metus. Sed eu ornare magna. In ac semper sem. Cras eget fringilla velit. Praesent convallis ex ac massa semper efficitur. Aliquam ac magna ut arcu ultrices ullamcorper a sit amet eros. Nunc congue massa sit amet leo lacinia cursus. Aenean porta non ligula et euismod.</p>
</vscode-demo>
</main>
</body>

</html>
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@
"@types/node": "^22.9.0",
"@typescript-eslint/eslint-plugin": "^8.13.0",
"@typescript-eslint/parser": "^8.13.0",
"@vscode-elements/webview-playground": "^1.2.2",
"@vscode-elements/webview-playground": "^1.3.0",
"@vscode/codicons": "^0.0.36",
"@web/dev-server": "^0.4.6",
"@web/dev-server-esbuild": "^1.0.3",
Expand Down
3 changes: 2 additions & 1 deletion src/vscode-divider/vscode-divider.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,12 @@ const styles: CSSResultGroup = [
defaultStyles,
css`
:host {
background-color: var(--vscode-widget-border);
background-color: var(--vscode-foreground);
display: block;
height: 1px;
margin-bottom: 10px;
margin-top: 10px;
opacity: 0.4;
}
`,
];
Expand Down