Emit click event on button enter or space keydown#245
Merged
bendera merged 2 commits intovscode-elements:mainfrom Jan 7, 2025
Merged
Emit click event on button enter or space keydown#245bendera merged 2 commits intovscode-elements:mainfrom
bendera merged 2 commits intovscode-elements:mainfrom
Conversation
Member
|
Thanks! I love to see how the contributors' list grows. :) How come it's a plain event and not a mouse (pointer?) event? I didn't write it to be argumentative, I just want to understand. |
Contributor
Author
|
No reason... |
Contributor
Author
|
I changed the event to be a MouseEvent because that's probably more in line with what consumers will be expecting. |
Member
|
Thanks! I don't want to publish a new release yet, but I've published a pre-release version on npm. So you can use it if you'd like.
|
Contributor
Author
|
Awesome, I'll pull it down :) Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #242
@bendera here is the PR we discussed :)