Skip to content

343 suggestion mode for single select #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bendera merged 6 commits into from
Mar 16, 2025
Merged

343 suggestion mode for single select #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
02293c3
Add placeholder option
bendera Mar 12, 2025
9109153
Create the new option on click
bendera Mar 13, 2025
ec7e09f
Add option by keyboard
bendera Mar 16, 2025
d6e2151
wip
bendera Mar 16, 2025
8cb9c66
Refactor the placeholder option rendering
bendera Mar 16, 2025
d85d368
Update changelog
bendera Mar 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
### Added

- Added **ToolbarButton** component.
- Added the `creatable` property to **SingleSelect**, allowing users to create new options in
combobox mode.

## [1.14.0] - 2025-03-06

Expand Down
43 changes: 43 additions & 0 deletions dev/vscode-multi-select/combobox-suggestion-mode.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>VSCode Elements</title>
<link
rel="stylesheet"
href="/node_modules/@vscode/codicons/dist/codicon.css"
id="vscode-codicon-stylesheet"
>
<script
type="module"
src="/node_modules/@vscode-elements/webview-playground/dist/index.js"
></script>
<script type="module" src="/dist/main.js"></script>
<script>
const logEvents = (selector, eventType) => {
document.querySelector(selector).addEventListener(eventType, (ev) => {
console.log(ev);
});
};
</script>
</head>

<body>
<main>
<vscode-demo>
<vscode-multi-select combobox creatable>
<vscode-option>Lorem</vscode-option>
<vscode-option>Ipsum</vscode-option>
<vscode-option>Dolor</vscode-option>
</vscode-multi-select>
<script type="module">
const sl = document.querySelector('vscode-multi-select');
sl.addEventListener('change', () => {
console.log(sl.value);
});
</script>
</vscode-demo>
</main>
</body>
</html>
43 changes: 43 additions & 0 deletions dev/vscode-multi-select/combobox.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>VSCode Elements</title>
<link
rel="stylesheet"
href="/node_modules/@vscode/codicons/dist/codicon.css"
id="vscode-codicon-stylesheet"
>
<script
type="module"
src="/node_modules/@vscode-elements/webview-playground/dist/index.js"
></script>
<script type="module" src="/dist/main.js"></script>
<script>
const logEvents = (selector, eventType) => {
document.querySelector(selector).addEventListener(eventType, (ev) => {
console.log(ev);
});
};
</script>
</head>

<body>
<main>
<vscode-demo>
<vscode-multi-select combobox>
<vscode-option>Lorem</vscode-option>
<vscode-option>Ipsum</vscode-option>
<vscode-option>Dolor</vscode-option>
</vscode-multi-select>
<script type="module">
const sl = document.querySelector('vscode-multi-select');
sl.addEventListener('change', () => {
console.log(sl.value);
});
</script>
</vscode-demo>
</main>
</body>
</html>
37 changes: 37 additions & 0 deletions dev/vscode-single-select/basic-example.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>VSCode Elements</title>
<link
rel="stylesheet"
href="/node_modules/@vscode/codicons/dist/codicon.css"
id="vscode-codicon-stylesheet"
>
<script
type="module"
src="/node_modules/@vscode-elements/webview-playground/dist/index.js"
></script>
<script type="module" src="/dist/main.js"></script>
<script>
const logEvents = (selector, eventType) => {
document.querySelector(selector).addEventListener(eventType, (ev) => {
console.log(ev);
});
};
</script>
</head>

<body>
<main>
<vscode-demo>
<vscode-single-select>
<vscode-option>Lorem</vscode-option>
<vscode-option>Ipsum</vscode-option>
<vscode-option>Dolor</vscode-option>
</vscode-single-select>
</vscode-demo>
</main>
</body>
</html>
43 changes: 43 additions & 0 deletions dev/vscode-single-select/combobox-suggestion-mode.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>VSCode Elements</title>
<link
rel="stylesheet"
href="/node_modules/@vscode/codicons/dist/codicon.css"
id="vscode-codicon-stylesheet"
>
<script
type="module"
src="/node_modules/@vscode-elements/webview-playground/dist/index.js"
></script>
<script type="module" src="/dist/main.js"></script>
<script>
const logEvents = (selector, eventType) => {
document.querySelector(selector).addEventListener(eventType, (ev) => {
console.log(ev);
});
};
</script>
</head>

<body>
<main>
<vscode-demo>
<vscode-single-select combobox creatable>
<vscode-option>Lorem</vscode-option>
<vscode-option>Ipsum</vscode-option>
<vscode-option>Dolor</vscode-option>
</vscode-single-select>
<script type="module">
const sl = document.querySelector('vscode-single-select');
sl.addEventListener('change', () => {
console.log(sl.value);
});
</script>
</vscode-demo>
</main>
</body>
</html>
43 changes: 43 additions & 0 deletions dev/vscode-single-select/combobox.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<!doctype html>
<html lang="en">
<head>
<meta charset="UTF-8">
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<title>VSCode Elements</title>
<link
rel="stylesheet"
href="/node_modules/@vscode/codicons/dist/codicon.css"
id="vscode-codicon-stylesheet"
>
<script
type="module"
src="/node_modules/@vscode-elements/webview-playground/dist/index.js"
></script>
<script type="module" src="/dist/main.js"></script>
<script>
const logEvents = (selector, eventType) => {
document.querySelector(selector).addEventListener(eventType, (ev) => {
console.log(ev);
});
};
</script>
</head>

<body>
<main>
<vscode-demo>
<vscode-single-select combobox>
<vscode-option>Lorem</vscode-option>
<vscode-option>Ipsum</vscode-option>
<vscode-option>Dolor</vscode-option>
</vscode-single-select>
<script type="module">
const sl = document.querySelector('vscode-single-select');
sl.addEventListener('change', () => {
console.log(sl.value);
});
</script>
</vscode-demo>
</main>
</body>
</html>
18 changes: 18 additions & 0 deletions src/includes/vscode-select/styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,24 @@ export default [
border-width: 1px;
}

.no-options {
align-items: center;
border-color: transparent;
border-style: solid;
border-width: 1px;
color: var(--vscode-foreground, #cccccc);
cursor: default;
display: flex;
font-family: var(--vscode-font-family, sans-serif);
font-size: var(--vscode-font-size, 13px);
font-weight: var(--vscode-font-weight, normal);
line-height: 18px;
min-height: calc(var(--vscode-font-size) * 1.3);
opacity: 0.85;
padding: 1px 3px;
user-select: none;
}

:host-context(body[data-vscode-theme-kind='vscode-high-contrast'])
.option.active,
:host-context(body[data-vscode-theme-kind='vscode-high-contrast-light'])
Expand Down
Loading