feat: add block prop to <vscode-button>
#555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: vscode-elements#554 Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
dankeboy36
force-pushed
the
fix/554/align-button-to-native-monaco-button
branch
from
1d50cb9 to
364bc80
Compare
dankeboy36
added a commit
to dankeboy36/vscode-elements-x
that referenced
this pull request
Nov 8, 2025
Ref: vscode-elements#555 Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
dankeboy36
pushed a commit
to dankeboy36/vscode-elements-x
that referenced
this pull request
Nov 8, 2025
## [0.1.3](0.1.2...0.1.3) (2025-11-08) ### Bug Fixes * align button height with Monaco metrics ([#7](#7)) ([6482f36](6482f36)), closes [vscode-elements#555](vscode-elements#555)
Signed-off-by: dankeboy36 <dankeboy36@gmail.com>
dankeboy36
changed the title
block prop to <vscode-button>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
blockprop to the<vscode-button>.This kind of button is 28px height, 100% width, with center-aligned label. Clients can align with native VS Code UX.
Closes ##554