Sourcery refactored master branch#1
Open
sourcery-ai[bot] wants to merge 1 commit intomasterfrom
Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| This program tries to predict the number of thefts from | ||
| the number of fire in the city of Chicago | ||
| """ | ||
|
|
Author
There was a problem hiding this comment.
Lines 41-53 refactored with the following changes:
- Convert for loop into call to sum() (
sum-comprehension)
This removes the following comments ( why? ):
# TO DO: write sess.run()
# Session runs optimizer to minimize loss and fetch the value of loss
| MNIST dataset: yann.lecun.com/exdb/mnist/ | ||
|
|
||
| """ | ||
|
|
Author
There was a problem hiding this comment.
Lines 29-84 refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
| MNIST dataset: yann.lecun.com/exdb/mnist/ | ||
|
|
||
| """ | ||
|
|
Author
There was a problem hiding this comment.
Lines 57-84 refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
| Author: Chip Huyen | ||
| Prepared for O'Reilly "A short course in TensorFlow" | ||
| """ | ||
|
|
Author
There was a problem hiding this comment.
Lines 17-35 refactored with the following changes:
- Replace unused for index with underscore (
for-index-underscore)
This removes the following comments ( why? ):
# do to 100 iterations
Comment on lines
-84
to
+89
| # assume the image has the label Chihuahua, which corresponds to class number 1 | ||
| label = 1 | ||
| image_file = IMAGE_PATH + 'friday.jpg' | ||
| tfrecord_file = IMAGE_PATH + 'friday.tfrecord' | ||
| write_tfrecord(label, image_file, tfrecord_file) | ||
| read_tfrecord(tfrecord_file) | ||
| # assume the image has the label Chihuahua, which corresponds to class number 1 | ||
| label = 1 | ||
| image_file = f'{IMAGE_PATH}friday.jpg' | ||
| tfrecord_file = f'{IMAGE_PATH}friday.tfrecord' | ||
| write_tfrecord(label, image_file, tfrecord_file) | ||
| read_tfrecord(tfrecord_file) |
Author
There was a problem hiding this comment.
Function main refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
Comment on lines
-110
to
+112
| writer = tf.summary.FileWriter('improved_graph/lr' + str(LEARNING_RATE), sess.graph) | ||
| writer = tf.summary.FileWriter( | ||
| f'improved_graph/lr{str(LEARNING_RATE)}', sess.graph | ||
| ) |
Author
There was a problem hiding this comment.
Function train_model refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-33
to
+35
| raise Exception('File ' + file_name + | ||
| ' might be corrupted. You should try downloading it with a browser.') | ||
| raise Exception( | ||
| f'File {file_name} might be corrupted. You should try downloading it with a browser.' | ||
| ) |
Author
There was a problem hiding this comment.
Function download refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
Comment on lines
-48
to
+49
| dictionary = dict() | ||
| dictionary = {} |
Author
There was a problem hiding this comment.
Function build_vocab refactored with the following changes:
- Replace
dict()with{}(dict-literal)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!