DatabasePager sometimes loads models with wrong textures

[ArepMM]

If we added models to scene via PagedLOD, it may be showed with wrong or corrupted textures. Then after few seconds viewer freeze and crash.
I found that vsgExamples/vsgdynamicload does the same things as databasepager - load, compile models and then add them to scene. And curious that it works fine always, but databasepager sometimes fail. I made a minimal example reproducing the problem. There are some results on glTF-Sample-Assets:

1. /Models/ABeautifulGame/glTF/ABeautifulGame.gltf - fail 2. /Models/Avocado/glTF/Avocado.gltf - success 3. But these models together - fails, avocado somehow got texture from beautiful game 4. Scene with many pagedLODs works fine, and I think thats why we rarely see the problem in our real applications, but... 5. Sometimes we got bugreports like this, some models with textures from another models, then viewer freeze and crash.

[ArepMM]

I created a PR with my test app for helping to investigate: vsg-dev/vsgExamples#389
My system: Windows 10, Vulkan 1.3.296.0, VulkanSceneGragh 1.1.14 and vsgXchange 1.1.11

[robertosfield]

I have reproduced the issue using:

$ vsgpagedlodtest ABeautifulGame/glTF/ABeautifulGame.gltf -d

Added -d to enable the Vulkan Validation Layer I then see lots of errors:

$ vsgpagedlodtest ABeautifulGame/glTF/ABeautifulGame.gltf -d
Sucessfully added pagedLOD for file ABeautifulGame/glTF/ABeautifulGame.gltf
Applied custom databasePager with autoscale models to the same size
Applied databasePager->targetMaxNumPagedLODWithHighResSubgraphs = 1500
info: gltf::Extensions::read_object() KHR_materials_transmission not supported.
info: gltf::Extensions::read_object() KHR_materials_volume not supported.
info: gltf::Extensions::read_object() KHR_materials_transmission not supported.
info: gltf::Extensions::read_object() KHR_materials_volume not supported.
Validation Error: [ VUID-vkCmdDrawIndexed-None-08600 ] | MessageID = 0x381a0272
vkCmdDrawIndexed(): The VkPipeline 0xab00000000ab (created with VkPipelineLayout 0xa900000000a9) statically uses descriptor set 1, but all sets 0 to 1 are not compatible with the pipeline layout bound with vkCmdBindDescriptorSets (VkPipelineLayout 0x840000000084)
Set 1 VkDescriptorSetLayoutBindingFlagsCreateInfo::bindingCount 6 doesn't match 4
The Vulkan spec states: If a a bound shader was created as a VkShaderEXT without the VK_SHADER_CREATE_DESCRIPTOR_HEAP_BIT_EXT flag or as part of a pipeline without the VK_PIPELINE_CREATE_2_DESCRIPTOR_HEAP_BIT_EXT flag, and that shader statically uses a set n, a descriptor set must have been bound to n at the same pipeline bind point, with a VkPipelineLayout that is compatible for set n, with the VkPipelineLayout used to create the current VkPipeline or the VkDescriptorSetLayout array used to create the current VkShaderEXT , as described in Pipeline Layout Compatibility (https://vulkan.lunarg.com/doc/view/1.4.341.1/linux/antora/spec/latest/chapters/drawing.html#VUID-vkCmdDrawIndexed-None-08600)
Objects: 2
    [0] VkPipeline 0xab00000000ab
    [1] VkPipelineLayout 0x840000000084

Validation Error: [ VUID-vkCmdDrawIndexed-None-08600 ] | MessageID = 0x381a0272
vkCmdDrawIndexed(): The VkPipeline 0xab00000000ab (created with VkPipelineLayout 0xa900000000a9) statically uses descriptor set 1, but all sets 0 to 1 are not compatible with the pipeline layout bound with vkCmdBindDescriptorSets (VkPipelineLayout 0x840000000084)
Set 1 VkDescriptorSetLayoutBindingFlagsCreateInfo::bindingCount 6 doesn't match 4
The Vulkan spec states: If a a bound shader was created as a VkShaderEXT without the VK_SHADER_CREATE_DESCRIPTOR_HEAP_BIT_EXT flag or as part of a pipeline without the VK_PIPELINE_CREATE_2_DESCRIPTOR_HEAP_BIT_EXT flag, and that shader statically uses a set n, a descriptor set must have been bound to n at the same pipeline bind point, with a VkPipelineLayout that is compatible for set n, with the VkPipelineLayout used to create the current VkPipeline or the VkDescriptorSetLayout array used to create the current VkShaderEXT , as described in Pipeline Layout Compatibility (https://vulkan.lunarg.com/doc/view/1.4.341.1/linux/antora/spec/latest/chapters/drawing.html#VUID-vkCmdDrawIndexed-None-08600)
Objects: 2
    [0] VkPipeline 0xab00000000ab
    [1] VkPipelineLayout 0x840000000084

Validation Error: [ VUID-vkCmdDrawIndexed-None-08600 ] | MessageID = 0x381a0272
vkCmdDrawIndexed(): The VkPipeline 0xab00000000ab (created with VkPipelineLayout 0xa900000000a9) statically uses descriptor set 1, but all sets 0 to 1 are not compatible with the pipeline layout bound with vkCmdBindDescriptorSets (VkPipelineLayout 0x840000000084)
Set 1 VkDescriptorSetLayoutBindingFlagsCreateInfo::bindingCount 6 doesn't match 4
The Vulkan spec states: If a a bound shader was created as a VkShaderEXT without the VK_SHADER_CREATE_DESCRIPTOR_HEAP_BIT_EXT flag or as part of a pipeline without the VK_PIPELINE_CREATE_2_DESCRIPTOR_HEAP_BIT_EXT flag, and that shader statically uses a set n, a descriptor set must have been bound to n at the same pipeline bind point, with a VkPipelineLayout that is compatible for set n, with the VkPipelineLayout used to create the current VkPipeline or the VkDescriptorSetLayout array used to create the current VkShaderEXT , as described in Pipeline Layout Compatibility (https://vulkan.lunarg.com/doc/view/1.4.341.1/linux/antora/spec/latest/chapters/drawing.html#VUID-vkCmdDrawIndexed-None-08600)
Objects: 2
    [0] VkPipeline 0xab00000000ab
    [1] VkPipelineLayout 0x840000000084

Validation Error: [ VUID-vkCmdDrawIndexed-None-08600 ] | MessageID = 0x381a0272
vkCmdDrawIndexed(): The VkPipeline 0xab00000000ab (created with VkPipelineLayout 0xa900000000a9) statically uses descriptor set 1, but all sets 0 to 1 are not compatible with the pipeline layout bound with vkCmdBindDescriptorSets (VkPipelineLayout 0x840000000084)
Set 1 VkDescriptorSetLayoutBindingFlagsCreateInfo::bindingCount 6 doesn't match 4
The Vulkan spec states: If a a bound shader was created as a VkShaderEXT without the VK_SHADER_CREATE_DESCRIPTOR_HEAP_BIT_EXT flag or as part of a pipeline without the VK_PIPELINE_CREATE_2_DESCRIPTOR_HEAP_BIT_EXT flag, and that shader statically uses a set n, a descriptor set must have been bound to n at the same pipeline bind point, with a VkPipelineLayout that is compatible for set n, with the VkPipelineLayout used to create the current VkPipeline or the VkDescriptorSetLayout array used to create the current VkShaderEXT , as described in Pipeline Layout Compatibility (https://vulkan.lunarg.com/doc/view/1.4.341.1/linux/antora/spec/latest/chapters/drawing.html#VUID-vkCmdDrawIndexed-None-08600)
Objects: 2
    [0] VkPipeline 0xab00000000ab
    [1] VkPipelineLayout 0x840000000084

Validation Error: [ VUID-vkCmdDrawIndexed-None-08600 ] | MessageID = 0x381a0272
vkCmdDrawIndexed(): The VkPipeline 0xab00000000ab (created with VkPipelineLayout 0xa900000000a9) statically uses descriptor set 1, but all sets 0 to 1 are not compatible with the pipeline layout bound with vkCmdBindDescriptorSets (VkPipelineLayout 0x840000000084)
Set 1 VkDescriptorSetLayoutBindingFlagsCreateInfo::bindingCount 6 doesn't match 4
The Vulkan spec states: If a a bound shader was created as a VkShaderEXT without the VK_SHADER_CREATE_DESCRIPTOR_HEAP_BIT_EXT flag or as part of a pipeline without the VK_PIPELINE_CREATE_2_DESCRIPTOR_HEAP_BIT_EXT flag, and that shader statically uses a set n, a descriptor set must have been bound to n at the same pipeline bind point, with a VkPipelineLayout that is compatible for set n, with the VkPipelineLayout used to create the current VkPipeline or the VkDescriptorSetLayout array used to create the current VkShaderEXT , as described in Pipeline Layout Compatibility (https://vulkan.lunarg.com/doc/view/1.4.341.1/linux/antora/spec/latest/chapters/drawing.html#VUID-vkCmdDrawIndexed-None-08600)
Objects: 2
    [0] VkPipeline 0xab00000000ab
    [1] VkPipelineLayout 0x840000000084

Validation Error: [ VUID-vkCmdDrawIndexed-None-08600 ] | MessageID = 0x381a0272
vkCmdDrawIndexed(): The VkPipeline 0xab00000000ab (created with VkPipelineLayout 0xa900000000a9) statically uses descriptor set 1, but all sets 0 to 1 are not compatible with the pipeline layout bound with vkCmdBindDescriptorSets (VkPipelineLayout 0x840000000084)
Set 1 VkDescriptorSetLayoutBindingFlagsCreateInfo::bindingCount 6 doesn't match 4
The Vulkan spec states: If a a bound shader was created as a VkShaderEXT without the VK_SHADER_CREATE_DESCRIPTOR_HEAP_BIT_EXT flag or as part of a pipeline without the VK_PIPELINE_CREATE_2_DESCRIPTOR_HEAP_BIT_EXT flag, and that shader statically uses a set n, a descriptor set must have been bound to n at the same pipeline bind point, with a VkPipelineLayout that is compatible for set n, with the VkPipelineLayout used to create the current VkPipeline or the VkDescriptorSetLayout array used to create the current VkShaderEXT , as described in Pipeline Layout Compatibility (https://vulkan.lunarg.com/doc/view/1.4.341.1/linux/antora/spec/latest/chapters/drawing.html#VUID-vkCmdDrawIndexed-None-08600)
Objects: 2
    [0] VkPipeline 0xab00000000ab
    [1] VkPipelineLayout 0x840000000084

Validation Error: [ VUID-vkCmdDrawIndexed-None-08600 ] | MessageID = 0x381a0272
vkCmdDrawIndexed(): The VkPipeline 0xab00000000ab (created with VkPipelineLayout 0xa900000000a9) statically uses descriptor set 1, but all sets 0 to 1 are not compatible with the pipeline layout bound with vkCmdBindDescriptorSets (VkPipelineLayout 0x840000000084)
Set 1 VkDescriptorSetLayoutBindingFlagsCreateInfo::bindingCount 6 doesn't match 4
The Vulkan spec states: If a a bound shader was created as a VkShaderEXT without the VK_SHADER_CREATE_DESCRIPTOR_HEAP_BIT_EXT flag or as part of a pipeline without the VK_PIPELINE_CREATE_2_DESCRIPTOR_HEAP_BIT_EXT flag, and that shader statically uses a set n, a descriptor set must have been bound to n at the same pipeline bind point, with a VkPipelineLayout that is compatible for set n, with the VkPipelineLayout used to create the current VkPipeline or the VkDescriptorSetLayout array used to create the current VkShaderEXT , as described in Pipeline Layout Compatibility (https://vulkan.lunarg.com/doc/view/1.4.341.1/linux/antora/spec/latest/chapters/drawing.html#VUID-vkCmdDrawIndexed-None-08600)
Objects: 2
    [0] VkPipeline 0xab00000000ab
    [1] VkPipelineLayout 0x840000000084

Validation Error: [ VUID-vkCmdDrawIndexed-None-08600 ] | MessageID = 0x381a0272
vkCmdDrawIndexed(): The VkPipeline 0xab00000000ab (created with VkPipelineLayout 0xa900000000a9) statically uses descriptor set 1, but all sets 0 to 1 are not compatible with the pipeline layout bound with vkCmdBindDescriptorSets (VkPipelineLayout 0x840000000084)
Set 1 VkDescriptorSetLayoutBindingFlagsCreateInfo::bindingCount 6 doesn't match 4
The Vulkan spec states: If a a bound shader was created as a VkShaderEXT without the VK_SHADER_CREATE_DESCRIPTOR_HEAP_BIT_EXT flag or as part of a pipeline without the VK_PIPELINE_CREATE_2_DESCRIPTOR_HEAP_BIT_EXT flag, and that shader statically uses a set n, a descriptor set must have been bound to n at the same pipeline bind point, with a VkPipelineLayout that is compatible for set n, with the VkPipelineLayout used to create the current VkPipeline or the VkDescriptorSetLayout array used to create the current VkShaderEXT , as described in Pipeline Layout Compatibility (https://vulkan.lunarg.com/doc/view/1.4.341.1/linux/antora/spec/latest/chapters/drawing.html#VUID-vkCmdDrawIndexed-None-08600)
Objects: 2
    [0] VkPipeline 0xab00000000ab
    [1] VkPipelineLayout 0x840000000084

Validation Error: [ VUID-vkCmdDrawIndexed-None-08600 ] | MessageID = 0x381a0272
vkCmdDrawIndexed(): The VkPipeline 0xab00000000ab (created with VkPipelineLayout 0xa900000000a9) statically uses descriptor set 1, but all sets 0 to 1 are not compatible with the pipeline layout bound with vkCmdBindDescriptorSets (VkPipelineLayout 0x840000000084)
Set 1 VkDescriptorSetLayoutBindingFlagsCreateInfo::bindingCount 6 doesn't match 4
The Vulkan spec states: If a a bound shader was created as a VkShaderEXT without the VK_SHADER_CREATE_DESCRIPTOR_HEAP_BIT_EXT flag or as part of a pipeline without the VK_PIPELINE_CREATE_2_DESCRIPTOR_HEAP_BIT_EXT flag, and that shader statically uses a set n, a descriptor set must have been bound to n at the same pipeline bind point, with a VkPipelineLayout that is compatible for set n, with the VkPipelineLayout used to create the current VkPipeline or the VkDescriptorSetLayout array used to create the current VkShaderEXT , as described in Pipeline Layout Compatibility (https://vulkan.lunarg.com/doc/view/1.4.341.1/linux/antora/spec/latest/chapters/drawing.html#VUID-vkCmdDrawIndexed-None-08600)
Objects: 2
    [0] VkPipeline 0xab00000000ab
    [1] VkPipelineLayout 0x840000000084

Validation Error: [ VUID-vkCmdDrawIndexed-None-08600 ] | MessageID = 0x381a0272
(Warning - This VUID has now been reported 10 times, which is the duplicate_message_limit value, this will be the last time reporting it).
vkCmdDrawIndexed(): The VkPipeline 0xab00000000ab (created with VkPipelineLayout 0xa900000000a9) statically uses descriptor set 1, but all sets 0 to 1 are not compatible with the pipeline layout bound with vkCmdBindDescriptorSets (VkPipelineLayout 0x840000000084)
Set 1 VkDescriptorSetLayoutBindingFlagsCreateInfo::bindingCount 6 doesn't match 4
The Vulkan spec states: If a a bound shader was created as a VkShaderEXT without the VK_SHADER_CREATE_DESCRIPTOR_HEAP_BIT_EXT flag or as part of a pipeline without the VK_PIPELINE_CREATE_2_DESCRIPTOR_HEAP_BIT_EXT flag, and that shader statically uses a set n, a descriptor set must have been bound to n at the same pipeline bind point, with a VkPipelineLayout that is compatible for set n, with the VkPipelineLayout used to create the current VkPipeline or the VkDescriptorSetLayout array used to create the current VkShaderEXT , as described in Pipeline Layout Compatibility (https://vulkan.lunarg.com/doc/view/1.4.341.1/linux/antora/spec/latest/chapters/drawing.html#VUID-vkCmdDrawIndexed-None-08600)
Objects: 2
    [0] VkPipeline 0xab00000000ab
    [1] VkPipelineLayout 0x840000000084

I don't know yet what the root cause of this, but these Validation errors should hopefully provide some clues.

[robertosfield]

I am investigating the issue and have now ruled out different behaviors in the vsgXchange::gltf, so we should be seeing the same basic scene graph in memory whether it's vsgviewer, vsgdynamicload or vsgpagedlodtest loading the data.

So... I'm now going to look at the compile traversal execution in each of the instances.

[robertosfield]

Still investigating but no breakthrough yet.

Currently it looks like the vsgpagedlodtest run only records one BindViewDependentState per frame while when running the same model through vsgdynamload results in multiple BindViewDependentState being called.

When the vsgpagedlodtest does record it's single BindViewDependentState but subsequent draw calls trigger a Vulkan Validation Errors due to incompatible vkLayout. I presume that the layout it changing through the loaded subgraph but there isn't a new bind of the ViewDependentState happening when it should.

More investigation required. I'll pick this up again tomorrow.