Skip to content

Fix keyboard modifier typos in Update Win32_Window.h#1076

Merged
robertosfield merged 2 commits intovsg-dev:masterfrom
jamierobertson1:master
Jan 20, 2024
Merged

Fix keyboard modifier typos in Update Win32_Window.h#1076
robertosfield merged 2 commits intovsg-dev:masterfrom
jamierobertson1:master

Conversation

@jamierobertson1
Copy link
Copy Markdown
Contributor

Pull Request Template

Description

Typos in vsgWin32::KeyboardMap::getKeySymbol prevented VK_RSHIFT and VK_RMENU key's (Right shift & Right Alt) being mapped to MODKEY_Shift and MODKEY_Alt modifiers.

Previously there were duplicate entries for VK_LSHIFT and VK_LMENU instead of their "R" counterparts.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested on windows with master. Keyboard modifiers work correctly for right shift & right alt key presses.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Typos in vsgWin32::KeyboardMap::getKeySymbol prevented VK_RSHIFT and VK_RMENU key's (Right shift & Right Alt) being mapped to MODKEY_Shift and MODKEY_Alt keys.
Fix keyboard modifier typos in Update Win32_Window.h
@robertosfield robertosfield merged commit 081c88a into vsg-dev:master Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants