Fix keyboard modifier typos in Update Win32_Window.h#1076
Merged
robertosfield merged 2 commits intovsg-dev:masterfrom Jan 20, 2024
Merged
Fix keyboard modifier typos in Update Win32_Window.h#1076robertosfield merged 2 commits intovsg-dev:masterfrom
robertosfield merged 2 commits intovsg-dev:masterfrom
Conversation
Typos in vsgWin32::KeyboardMap::getKeySymbol prevented VK_RSHIFT and VK_RMENU key's (Right shift & Right Alt) being mapped to MODKEY_Shift and MODKEY_Alt keys.
Fix keyboard modifier typos in Update Win32_Window.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Typos in vsgWin32::KeyboardMap::getKeySymbol prevented VK_RSHIFT and VK_RMENU key's (Right shift & Right Alt) being mapped to MODKEY_Shift and MODKEY_Alt modifiers.
Previously there were duplicate entries for VK_LSHIFT and VK_LMENU instead of their "R" counterparts.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested on windows with master. Keyboard modifiers work correctly for right shift & right alt key presses.
Checklist: