Skip to content

[FIXED] depthResolveAttachment to use LOAD_OP_DONT_CARE#812

Merged
robertosfield merged 1 commit intovsg-dev:masterfrom
siystar:loadop
May 13, 2023
Merged

[FIXED] depthResolveAttachment to use LOAD_OP_DONT_CARE#812
robertosfield merged 1 commit intovsg-dev:masterfrom
siystar:loadop

Conversation

@siystar
Copy link
Copy Markdown

@siystar siystar commented May 13, 2023

Pull Request Template

Description

Fixed depthResolveAttachment's loadOp to match the resolveAttachment's LOAD_OP_DONT_CARE.

The Vulkan spec states: "At the end of each subpass, multisample resolve operations read the subpass's depth/stencil attachment, and resolve the samples for each pixel to the same pixel location in the corresponding resolve attachment."

Because all pixels are written by the resolve operation, it's possible to enable LOAD_OP_DONT_CARE.

How Has This Been Tested?

Tested a multisampled renderpass with requiresDepthRead=true

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@robertosfield robertosfield merged commit 6fb0fd4 into vsg-dev:master May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants