[FIXED] vkCreateRenderPass2KHR support#813
Merged
robertosfield merged 2 commits intovsg-dev:masterfrom May 13, 2023
Merged
Conversation
added 2 commits
May 13, 2023 08:02
Fixed vsg::RenderPass to support VK_KHR_create_renderpass2 for Vulkan versions less than 1.2. Fixed Vulkan 1.2 check to include the physicalDevice's apiVersion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Fixed vsg::RenderPass to support VK_KHR_create_renderpass2 for Vulkan versions less than 1.2. Fixed Vulkan 1.2 check to include the physicalDevice's apiVersion.
The Vulkan spec 3.7.2. states: "Device-level functionality added by a device extension that is dispatched from a VkDevice [...] must not be used unless that extension is supported by the device as determined by vkEnumerateDeviceExtensionProperties, and that extension is enabled in VkDeviceCreateInfo. [...] Device-level functionality or behavior added by a new core version of the API must not be used unless it is supported by the device as determined by VkPhysicalDeviceProperties::apiVersion and the specified version of VkApplicationInfo::apiVersion."
Type of change
How Has This Been Tested?
Tested that depth resolve attachment is no longer blank when VkInstance is created with apiVersion 1.1
Checklist: