Skip to content

[FIXED] vkCreateRenderPass2KHR support#813

Merged
robertosfield merged 2 commits intovsg-dev:masterfrom
siystar:createrenderpass2
May 13, 2023
Merged

[FIXED] vkCreateRenderPass2KHR support#813
robertosfield merged 2 commits intovsg-dev:masterfrom
siystar:createrenderpass2

Conversation

@siystar
Copy link
Copy Markdown

@siystar siystar commented May 13, 2023

Pull Request Template

Description

Fixed vsg::RenderPass to support VK_KHR_create_renderpass2 for Vulkan versions less than 1.2. Fixed Vulkan 1.2 check to include the physicalDevice's apiVersion.

The Vulkan spec 3.7.2. states: "Device-level functionality added by a device extension that is dispatched from a VkDevice [...] must not be used unless that extension is supported by the device as determined by vkEnumerateDeviceExtensionProperties, and that extension is enabled in VkDeviceCreateInfo. [...] Device-level functionality or behavior added by a new core version of the API must not be used unless it is supported by the device as determined by VkPhysicalDeviceProperties::apiVersion and the specified version of VkApplicationInfo::apiVersion."

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested that depth resolve attachment is no longer blank when VkInstance is created with apiVersion 1.1

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

siystar added 2 commits May 13, 2023 08:02
Fixed vsg::RenderPass to support VK_KHR_create_renderpass2 for Vulkan versions less than 1.2. Fixed Vulkan 1.2 check to include the physicalDevice's apiVersion.
@robertosfield robertosfield merged commit c87b4cc into vsg-dev:master May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants