Make created REST API secret stable#11
Merged
Merged
Conversation
glrf
force-pushed
the
fix/stable-pw
branch
2 times, most recently
from
9888ee6 to
7353ca6
Compare
The feature of the helm chart to generate a secret for the REST API doesn't work through the component. It regenerates the password every time. This PR removes the password and adds a hook job that sets the password if (and only if) it isn't set yet
Kidswiss
approved these changes
Jun 30, 2023
| @@ -0,0 +1,41 @@ | |||
| /** | |||
| * Fixup images that are missing tags | |||
Contributor
Author
There was a problem hiding this comment.
Yes I hate it too. But I don't know what else to do 🙈
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature of the helm chart to generate a secret for the REST API doesn't work through the component. It regenerates the password every time.
This PR removes the password and adds a hook job that sets the password if (and only if) it isn't set yet
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.