Skip to content

Add option to define namespace labels and annotations#12

Merged
glrf merged 1 commit into
masterfrom
feat/namespace-label-annotation
Jun 30, 2023
Merged

Add option to define namespace labels and annotations#12
glrf merged 1 commit into
masterfrom
feat/namespace-label-annotation

Conversation

@glrf

@glrf glrf commented Jun 30, 2023

Copy link
Copy Markdown
Contributor

This gives us some flexibilty and can be helpful in multiple situations. The main usecase currently is that we can schedule stackgres on infra nodes on OpenShift using the annotation openshift.io/node-selector

Checklist

  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.

This gives us some flexibilty and can be helpful in multiple situations.
The main usecase currently is that we can schedule stackgres on infra
nodes on OpenShift using the annotation `openshift.io/node-selector`
@glrf glrf added the enhancement New feature or request label Jun 30, 2023
@glrf glrf self-assigned this Jun 30, 2023
@glrf glrf requested review from a team, Kidswiss and TheBigLee and removed request for a team June 30, 2023 11:02
@glrf glrf marked this pull request as ready for review June 30, 2023 11:03

@zugao zugao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glrf glrf merged commit 37e83e0 into master Jun 30, 2023
@glrf glrf deleted the feat/namespace-label-annotation branch June 30, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants