Skip to content

Fixes#13

Open
matthiask wants to merge 5 commits intovsoch:mainfrom
matthiask:fixes
Open

Fixes#13
matthiask wants to merge 5 commits intovsoch:mainfrom
matthiask:fixes

Conversation

@matthiask
Copy link
Copy Markdown

@matthiask matthiask commented Mar 30, 2026

I wanted to fix action-updater. Not everything here is strictly required but I wanted to do some housekeeping as well.

The most important part is that LooseVersion doesn't extend Version anymore since Version started using __slots__ and now inheriting that breaks with the following error:

    class VersionWrapper(Wrapper, LooseVersion):
TypeError: multiple bases have instance lay-out conflict

I installed action-updater with uv tool install action-updater --with-editable ~/projects/pipelib/ and now it works fine again!

It imports doc build dependencies which aren't installed in the test environment.
Black throws errors in my local environment with these settings.
…ple times is broken

This should hopefully avoid the following error:

    class VersionWrapper(Wrapper, LooseVersion):
TypeError: multiple bases have instance lay-out conflict
Old systems print nothing, newer print:

$ which singularity
/usr/bin/which: no singularity in (...)

Also, switch the implementation to use `shutil.which` instead of
shelling out to `which`. Keep the `strip_newline` parameter which is now
unused.
@matthiask matthiask changed the title Fix tests Fixes Mar 30, 2026
@vsoch
Copy link
Copy Markdown
Owner

vsoch commented Mar 30, 2026

@matthiask thank you for this PR! I have a few deadlines into April but I'll have time to look after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants