Open
Conversation
It imports doc build dependencies which aren't installed in the test environment.
Black throws errors in my local environment with these settings.
…ple times is broken
This should hopefully avoid the following error:
class VersionWrapper(Wrapper, LooseVersion):
TypeError: multiple bases have instance lay-out conflict
Old systems print nothing, newer print: $ which singularity /usr/bin/which: no singularity in (...) Also, switch the implementation to use `shutil.which` instead of shelling out to `which`. Keep the `strip_newline` parameter which is now unused.
Owner
|
@matthiask thank you for this PR! I have a few deadlines into April but I'll have time to look after that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to fix action-updater. Not everything here is strictly required but I wanted to do some housekeeping as well.
The most important part is that
LooseVersiondoesn't extendVersionanymore sinceVersionstarted using__slots__and now inheriting that breaks with the following error:I installed action-updater with
uv tool install action-updater --with-editable ~/projects/pipelib/and now it works fine again!