CVE-2013-7440 doesn't apply to Python 2.7#10
Merged
vstinner merged 1 commit intoAug 20, 2018
Conversation
Add a note explaining that although the CVE description says that this affects versions of Python 2.7 before 2.7.9, the `match_hostname` function was actually only added in 2.7.9, and was added with this fix already applied. (It's hard to trawl through the history and work out what's happening otherwise)
Owner
|
I merged your PR. It should be online in 15 min. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a note explaining that although the CVE description says that this affects versions of Python 2.7 before 2.7.9, the
match_hostnamefunction was actually only added in 2.7.9, and was added with this fix already applied.(It's hard to trawl through the history and work out what's happening otherwise)
See commit daeb925cc88cc8fed2030166ade641de28edb396 to cpython for when the actual change was made.