Skip to content

Add cookiejar path related security issue#15

Merged
vstinner merged 7 commits into
vstinner:masterfrom
tirkarthi:add-cookie-poc
Jun 5, 2019
Merged

Add cookiejar path related security issue#15
vstinner merged 7 commits into
vstinner:masterfrom
tirkarthi:add-cookie-poc

Conversation

@tirkarthi
Copy link
Copy Markdown
Contributor

I had it in my fork and forgot to push it. bpo 30458 is also fixed but not updated. I will add them. I am opening this as WIP to make sure I don't forget it.

Comment thread vulnerabilities.yaml Outdated

- name: "CVE-2019-9947: CRLF injection attack in urllib"
cve: CVE-2019-9947
bpo: 30458
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is already tracked.

Comment thread vulnerabilities.yaml Outdated
disclosure: "2019-01-03 (Python issue bpo-35647 reported)"
reported-at: "2019-01-03"
reported-by: "Karthikeyan Singaravelan"
affected-versions:
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove affected-versions, it's redundant.

Comment thread vulnerabilities.yaml Outdated

- name: "bpo-35755: Remove current directory from posixpath.defpath"
bpo: 35755
disclosure: "2019-01-17 (Reported by bpo-35755)"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disclosure, reported-at, reported-by and affected-versions are generated automatically.

Comment thread vulnerabilities.yaml Outdated
@tirkarthi
Copy link
Copy Markdown
Contributor Author

I have removed the auto-generated fields mentioned. I removed the urllib and defpath items as suggested. This PR adds only the cookiejar path related vulnerability.

@tirkarthi tirkarthi changed the title Add cookiejar, path and http related security issues Add cookiejar path related security issue Jun 4, 2019
Comment thread vulnerabilities.yaml Outdated
`http.cookiejar.DefaultCookiePolicy` policy. Patch by Karthikeyan
Singaravelan.

- name: "bpo-35647: Incorrect validation of path in http.cookiejar"
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove "bpo-35647: " prefix.

Comment thread vulnerabilities.yaml Outdated
- 3.8: 0e1f1f01058bd4a9b98cfe443214adecc019a38c
description: |
Cookies of example.com with path=/any where sent to example.com/anybad/
while using a cookiejar with http.cookiejar.DefaultCookiePolicy policy.
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use reST syntax here for better rendering:

    Cookies of ``example.com`` with ``path=/any`` where sent to ``example.com/anybad/``
    while using a cookiejar with ``http.cookiejar.DefaultCookiePolicy`` policy.

@vstinner vstinner merged commit 594858b into vstinner:master Jun 5, 2019
@vstinner
Copy link
Copy Markdown
Owner

vstinner commented Jun 5, 2019

Thanks, merged. It's good to see more contributors on this project ;-) I was feeling alone :-D

@tirkarthi: Can you try to add a script to detect if Python is vulnerable to bpo-35647 in check-python-vuln//check-python-vuln.py?

@tirkarthi
Copy link
Copy Markdown
Contributor Author

Thanks Victor for merging it. Sure, I will add a script as another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants