July PyPI Vulnerabilities#29
Merged
Merged
Conversation
pradyunsg
approved these changes
Jul 28, 2021
pradyunsg
left a comment
pradyunsg
left a comment
There was a problem hiding this comment.
Content looks great! I only have non-blocking nit-picky concerns. :)
Comment on lines
+5
to
+7
| An exploitable vulnerability in the mechanisms for deleting legacy | ||
| documentation hosting deployment tooling on `PyPI <https://pypi.org>`_ was | ||
| discovered by a security researcher, which would allow an attacker to remove documentation for projects not under their control. |
There was a problem hiding this comment.
nit: Let's either wrap this at a specific line, or not wrap this at all. 🙈
| following guidelines in security policy on `pypi.org | ||
| <https://pypi.org/security/>`_) | ||
| * 2021-07-26 (**+1days**): Fix is implemented and deployed in `commit 33ad32 | ||
| <https://github.com/pypa/warehouse/commit/33ad326aab676b74bde3ecad686cf144e8c98fc9>`_ |
There was a problem hiding this comment.
nit: some references use the URLs of the form:
https://github.com/pypa/warehouse/commit/33ad326aab676b74bde3ecad686cf144e8c98fc9
while others use:
https://github.com/pypa/warehouse/pull/9846/commits/50bd16422889d653127d373c9615516bf883a394
Let's use the former, uniformly throughout?
Contributor
Author
|
@pradyunsg Added you as a collaborator on my fork if you'd like to push those changes. |
Ry0taK
reviewed
Jul 28, 2021
Contributor
Ry0taK
left a comment
Ry0taK
left a comment
There was a problem hiding this comment.
Leaving some reviews. Thank you so much for the write-up!
Co-authored-by: RyotaK <49341894+Ry0taK@users.noreply.github.com>
di
commented
Jul 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cc @ewdurbin)