PyPI 2022-05-24: remove comment regarding email protections#34
Merged
Conversation
this paragraph is inaccurate, we do not require a verified email address to perform a password reset, see https://github.com/pypa/warehouse/blob/bd81ae8bae40fcd2736e47b65912db297a993339/warehouse/accounts/models.py#L165-L174 which is the only gate on password reset requests. the email verification concerns noted in this paragraph are more to do with deliverability and reputation than security and would not have changed the course of this incident.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this paragraph is inaccurate, we do not require a verified email address to perform a password reset, see https://github.com/pypa/warehouse/blob/bd81ae8bae40fcd2736e47b65912db297a993339/warehouse/accounts/models.py#L165-L174 which is the only gate on password reset requests.
the email verification concerns noted in this paragraph are more to do with deliverability and reputation than security and would not have changed the course of this incident.