Skip to content

Add CVE-2018-25032: vulnerable zlib 1.2.11#39

Merged
vstinner merged 2 commits into
vstinner:mainfrom
CharlieZhao95:zlib
Sep 21, 2022
Merged

Add CVE-2018-25032: vulnerable zlib 1.2.11#39
vstinner merged 2 commits into
vstinner:mainfrom
CharlieZhao95:zlib

Conversation

@CharlieZhao95
Copy link
Copy Markdown
Contributor

#36

Comment thread vulnerabilities.yaml Outdated
Comment on lines +1994 to +1998
affected-versions:
- '3.10'
- '3.9'
- '3.8'
- '3.7'
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this list is correct not useful, the tool should compute it automatically.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, this seems to be a redundant member and we should remove it. Maybe we should change template at the top of vulnerabilities.yaml as well.

# Template:
# - name: ""
...
#   fixed-in:
#    - '3.x': commit_sha1
#    - '3.y': commit_sha1
#   affected-versions:
#    - "x.y"
#   description: |

Comment thread vulnerabilities.yaml Outdated

On Windows, you could fix this vulnerability by updating zlib to
1.2.12 in Windows builds. On Linux and macOS, you can fix it by specifying
the dynamically link version of zlib.
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to mention that on Linux and macOS, Python uses the system zlib library?

Copy link
Copy Markdown
Contributor Author

@CharlieZhao95 CharlieZhao95 Sep 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to mention that on Linux and macOS, Python uses the system zlib library?

By default, Python uses the system zlib to build. We can also specify the version of zlib by setting CPPFLAGS and LDFLAGS. Maybe I could describe the solution in more detail :)

@vstinner vstinner merged commit bcfa53a into vstinner:main Sep 21, 2022
@vstinner
Copy link
Copy Markdown
Owner

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants