Fixing scenario where false unavailable items are show on ReviewBlock#184
Conversation
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What does this PR do?
Fixes seller resolution in
ReviewBlockduring refId validation (Copy/Paste and Upload flows).Problem: After
skuFromRefIds, seller data was taken frommappedRefId, which was only filled for items found in the autocomplete restriction check. When an item was missing from that map, the UI got:rowData.sellers→ no seller dropdown even when the API returned multiple sellerssellerWithStock→ false "Restricted Item" even when stock existed on another sellerThis showed up in stores with multiple sellers per SKU (e.g. default seller
"1"without stock + marketplace seller"cromosolsc1"with stock on sales channel4).Solution:
skuFromRefIdsAPI response (refIdApiMap)availableorpartiallyAvailablestockvtexSku,unitMultiplier, andavailableQuantitysetRestriction/checkRestrictionautocomplete logic that fed the brokenmappedRefIdflowHow to test it?
Workspace
Example: RefId
1006→ SKU12250, sellers"1"(withoutStock) and"cromosolsc1"(available).1006,1).cromosolsc1/CROMOSOL)Optional: In devtools, confirm
skuFromRefIdsreturns multiple sellers and the review row hassellers.length > 1and a resolvedseller.Screenshots
Before:

After:
