Skip to content

Replace navigate with location.assign#460

Merged
bivillar merged 2 commits into
masterfrom
fix/return-url
Jun 1, 2020
Merged

Replace navigate with location.assign#460
bivillar merged 2 commits into
masterfrom
fix/return-url

Conversation

@bivillar
Copy link
Copy Markdown
Contributor

@bivillar bivillar commented May 27, 2020

What is the purpose of this pull request?

Fix redirect after login.

What problem is this solving?

navigate from render-runtime parses the query string and is no longer re-encoding it. Since the returnUrl query string needs to be encoded for the redirect to work, the navigate method had to be replaced.

How should this be manually tested?

  1. Without login into your store account, try reaching this page: https://challenge--recorrenciaqa.myvtex.com/account#/orders
  • it should redirect you to log in.
  1. After logging in, you should be redirected to the URL above.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd
Copy link
Copy Markdown
Contributor

vtex-io-ci-cd Bot commented May 27, 2020

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch

  • Minor

  • Major

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link
Copy Markdown

vtex-io-docs-bot Bot commented May 27, 2020

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@bivillar bivillar marked this pull request as ready for review May 27, 2020 21:09
@bivillar bivillar requested a review from a team as a code owner May 27, 2020 21:09
@bivillar bivillar requested review from klzns and rafarubim May 27, 2020 21:10
@bivillar bivillar self-assigned this May 27, 2020
@bivillar bivillar added the bug Something isn't working label May 27, 2020
@bivillar bivillar merged commit 33fc282 into master Jun 1, 2020
@bivillar bivillar deleted the fix/return-url branch June 1, 2020 18:04
@vtex-io-ci-cd
Copy link
Copy Markdown
Contributor

vtex-io-ci-cd Bot commented Jun 1, 2020

Your PR has been merged! App is being published. 🚀
Version 2.95.5 → 2.95.6

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.store@2.95.6

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

This was referenced Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants