Skip to content

fix(dialog): Added class for Entity Tweaks windows for 1.8.x #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
anthonyronda merged 1 commit into from
Mar 27, 2023
Merged

fix(dialog): Added class for Entity Tweaks windows for 1.8.x #351

anthonyronda merged 1 commit into from
Mar 27, 2023

Conversation

@bakbakbakbakbak
Copy link
Collaborator

@bakbakbakbakbak bakbakbakbakbak commented Feb 11, 2023

Putting these two in the same as it is just for convenience for testing purposes.

@bakbakbakbakbak bakbakbakbakbak changed the title Enhancement(test): ItemTypes helper & minor modification to Entity Tweaks Enhancement(test): ItemTypes helper & minor modification to Entity Tweaks for 1.8.x Feb 11, 2023
@bakbakbakbakbak bakbakbakbakbak changed the title Enhancement(test): ItemTypes helper & minor modification to Entity Tweaks for 1.8.x enhancement(test): ItemTypes helper & minor modification to Entity Tweaks for 1.8.x Feb 11, 2023
@anthonyronda
Copy link
Member

anthonyronda commented Feb 28, 2023

Could you describe what for, or provide an example of use, for the ItemTypes? Not opposed just interested. Perhaps the currently commented out Item CRUD tests? Or sheet-item-tests.ts?

@bakbakbakbakbak
Copy link
Collaborator Author

bakbakbakbakbak commented Feb 28, 2023 •
edited
Loading

Could you describe what for, or provide an example of use, for the ItemTypes? Not opposed just interested. Perhaps the currently commented out Item CRUD tests? Or sheet-item-tests.ts?

Mainly because it is being reused in a lot of the tests, and in case we need to add/remove item types later, one location would is simpler to maintain. That was the reasoning of moving this to testUtils.ts!

With the full test suite, including actors, it is reused here:
image

@anthonyronda
Copy link
Member

anthonyronda commented Feb 28, 2023

I saw it was cherry picked for #356 ? So is this still necessary here?

@bakbakbakbakbak
Copy link
Collaborator Author

bakbakbakbakbak commented Feb 28, 2023

I saw it was cherry picked for #356 ? So is this still necessary here?

Indeed, it is not necessary here if/when that gets merged! At the point I submitted this PR I hadn't started #356 yet.

@bakbakbakbakbak bakbakbakbakbak force-pushed the enhancement/test_helpers branch from 9c33cea to dc94fff Compare March 3, 2023 15:23
@bakbakbakbakbak bakbakbakbakbak force-pushed the enhancement/test_helpers branch from dc94fff to 06b6f65 Compare March 5, 2023 08:25
@bakbakbakbakbak
Copy link
Collaborator Author

bakbakbakbakbak commented Mar 5, 2023

Made this atomic, as part of it is included in #356 , making this just a fix for entity tweaks lacking class like other windows.

@bakbakbakbakbak bakbakbakbakbak changed the title enhancement(test): ItemTypes helper & minor modification to Entity Tweaks for 1.8.x fix(dialog): Added class for Entity Tweaks windows for 1.8.x Mar 5, 2023
anthonyronda
anthonyronda approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@anthonyronda anthonyronda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anthonyronda anthonyronda merged commit ee94e17 into vttred:1.8.x Mar 27, 2023
@bakbakbakbakbak bakbakbakbakbak mentioned this pull request Mar 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anthonyronda anthonyronda anthonyronda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bakbakbakbakbak @anthonyronda