fix: remove stale vsomeip interop stubs that were never fully landed#237
fix: remove stale vsomeip interop stubs that were never fully landed#237
Conversation
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 38 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
368b1a5 to
651056f
Compare
An earlier attempt at vsomeip interoperability testing was started but abandoned before completion. Only partial scaffolding landed in main (CMake option, add_subdirectory call, doc references) while the actual vsomeip_interop directory was never committed, leaving a broken build path and misleading claims. Clean up: - Remove BUILD_VSOMEIP_INTEROP CMake option - Remove add_subdirectory(vsomeip_interop) gated block - Remove protocol_checker README pointer to non-existent directory - Remove false "interoperability testing passed" claim - Remove false "AUTOSAR conformance validated" claim — the project tests against the Open SOME/IP spec, not an AUTOSAR conformance suite - Replace inflated "AUTOSAR Compliance Levels" section with honest "Open SOME/IP Specification Coverage" framing Closes #233
651056f to
30a1d67
Compare
Summary
BUILD_VSOMEIP_INTEROPCMake option and itsadd_subdirectory(vsomeip_interop)call — thevsomeip_interop/directory was never committed, so enabling this option would break the buildexamples/vsomeip_interop/directoryThese were leftovers from an earlier interop effort that was abandoned but not properly reverted, combined with aspirational doc claims that were never backed by actual testing.
Closes #233
Test plan
cmake -DBUILD_VSOMEIP_INTEROP=ONis no longer accepted (option removed)cmake .. && makestill builds cleanlyvsomeip_interopandBUILD_VSOMEIP_INTEROPin tracked files — should return zero matches