Skip to content

fix: remove stale vsomeip interop stubs that were never fully landed#237

Merged
vtz merged 1 commit intomainfrom
fix/remove-vsomeip-interop-stubs
Apr 18, 2026
Merged

fix: remove stale vsomeip interop stubs that were never fully landed#237
vtz merged 1 commit intomainfrom
fix/remove-vsomeip-interop-stubs

Conversation

@vtz
Copy link
Copy Markdown
Owner

@vtz vtz commented Apr 18, 2026

Summary

  • Removes the BUILD_VSOMEIP_INTEROP CMake option and its add_subdirectory(vsomeip_interop) call — the vsomeip_interop/ directory was never committed, so enabling this option would break the build
  • Removes the protocol_checker README pointer to the non-existent examples/vsomeip_interop/ directory
  • Removes false "interoperability testing passed" and "AUTOSAR conformance validated" claims from test documentation — the project tests against the Open SOME/IP spec, not an AUTOSAR conformance suite
  • Replaces inflated "AUTOSAR Compliance Levels" framing with honest "Open SOME/IP Specification Coverage"

These were leftovers from an earlier interop effort that was abandoned but not properly reverted, combined with aspirational doc claims that were never backed by actual testing.

Closes #233

Test plan

  • Verify cmake -DBUILD_VSOMEIP_INTEROP=ON is no longer accepted (option removed)
  • Verify cmake .. && make still builds cleanly
  • Grep for vsomeip_interop and BUILD_VSOMEIP_INTEROP in tracked files — should return zero matches

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 18, 2026

Warning

Rate limit exceeded

@vtz has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 57 minutes and 38 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 57 minutes and 38 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b96830bd-a328-4a60-80c5-30cade3c8ba2

📥 Commits

Reviewing files that changed from the base of the PR and between a5c83f7 and 30a1d67.

📒 Files selected for processing (5)
  • CMakeLists.txt
  • examples/CMakeLists.txt
  • examples/protocol_checker/README.md
  • tests/100_PERCENT_COVERAGE_ANALYSIS.md
  • tests/COMPREHENSIVE_TESTING_GUIDE.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-vsomeip-interop-stubs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vtz vtz force-pushed the fix/remove-vsomeip-interop-stubs branch from 368b1a5 to 651056f Compare April 18, 2026 20:53
An earlier attempt at vsomeip interoperability testing was started but
abandoned before completion. Only partial scaffolding landed in main
(CMake option, add_subdirectory call, doc references) while the actual
vsomeip_interop directory was never committed, leaving a broken build
path and misleading claims.

Clean up:
- Remove BUILD_VSOMEIP_INTEROP CMake option
- Remove add_subdirectory(vsomeip_interop) gated block
- Remove protocol_checker README pointer to non-existent directory
- Remove false "interoperability testing passed" claim
- Remove false "AUTOSAR conformance validated" claim — the project
  tests against the Open SOME/IP spec, not an AUTOSAR conformance suite
- Replace inflated "AUTOSAR Compliance Levels" section with honest
  "Open SOME/IP Specification Coverage" framing

Closes #233
@vtz vtz force-pushed the fix/remove-vsomeip-interop-stubs branch from 651056f to 30a1d67 Compare April 18, 2026 20:54
@vtz vtz merged commit 85b4c91 into main Apr 18, 2026
51 checks passed
@vtz vtz deleted the fix/remove-vsomeip-interop-stubs branch April 18, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interop tests

1 participant