-
Notifications
You must be signed in to change notification settings - Fork 530
noUiSlider unit test #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
icebob
merged 19 commits into
vue-generators:master
from
lionel-bijaoui:LB_noUiSlider_unit_test
Aug 24, 2016
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6d10687
fix: add disabled option to noUiSlider field
59d5036
test: improve testing of noUiSlider
2d2a819
improve code quality
icebob cd7029f
improve code quality
icebob 2e7380f
test: progress on noUiSlider
e338e6d
fix: Cleavejs better mask definition
dfef1f1
dev: noUiSlider with scale
136b112
test: querySelector instead of querySelectorAll
99b6a4d
fix: handle missing library better
4ab7a8e
:up: dep: update dependencies
icebob c169cb3
fix: add disabled option to noUiSlider field
42c9ea9
test: improve testing of noUiSlider
dea27a2
test: progress on noUiSlider
34a6401
fix: Cleavejs better mask definition
e1b4126
dev: noUiSlider with scale
00bfbda
test: querySelector instead of querySelectorAll
ec93745
fix: handle missing library better
6e2fef0
Merge branch 'LB_noUiSlider_unit_test' of github.com:lionel-bijaoui/v…
a2665dd
fix: lint error
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| $(function() { | ||
| let App = require("./App.vue"); | ||
|
|
||
| new Vue({ | ||
| let app = new Vue({ | ||
| el: "body", | ||
| components: { | ||
| App | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| <template lang="jade"> | ||
| div.slider | ||
| div.slider(:disabled="disabled") | ||
| </template> | ||
|
|
||
| <script> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,10 @@ | ||
| // require all test files (files that ends with .spec.js) | ||
| var testsContext = require.context('./specs', true, /\.spec$/); | ||
| var testsContext = require.context("./specs", true, /\.spec$/); | ||
| testsContext.keys().forEach(testsContext); | ||
|
|
||
|
|
||
| // require all src files except main.js for coverage. | ||
| // you can also change this to match only the subset of files that | ||
| // you want coverage for. | ||
| var srcContext = require.context('src', true, /\.(js|vue)$/); | ||
| var srcContext = require.context("src", true, /\.(js|vue)$/); | ||
| srcContext.keys().forEach(srcContext); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This modifications place in
itinsteadThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I do that, the value don't change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, strange. I will test it.
But
before()runs before allit, so this solution is not precise.