V3 #599

vimalptl · 2019-02-27T22:31:46Z

Please check if the PR fulfills these requirements

The commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Streamlining of schema

Use an event bus for most events Breaking: validate is a promise since now all validation is asynchronous

Update dep

- Remove some skip - Fix some test

Better groups and new validation mechanic

- Possibility to use scoped-slot to customise fully how label, help or hint are build - Little change to the structure to make it easy to do this - Heavy use of scoped-slot - Expose `field` object and `getValueFromOption` function

- Possibility to use scoped-slot to customise fully how errors are build - Expose `errors` object, `field` object and `getValueFromOption` function

- Create a new dev project to test custom and project - Remove custom code from "full" dev project

- Label with icon depending on field input type - Help with support for Markdown - Errors displayed in a table - Hint with icon and color

- Remove forgotten `only`

- Code coverage is back ! - Update dependencies

formGroup now use the correct class name for error when looking for them

Add Help in `form-group`

- Fix fieldUpload

…tion Code coverage reactivation

Fix deep property path not working

Implement #501 #509 #521 #522

- Possibility to use scoped-slot to customise fully how legend is build - Expose `group` and `groupLegend` in slot prop

Custom legend block for group

- No more core vs full since both are the same right now - Optionnal fields will be removed from it in future update

- Update dependencies - Export dist files

Release v3.0.0-beta.7

Big fix: v3 - Remove event listeners in abstractField for current context only

zoul0813 · 2019-02-28T02:21:02Z

wtf?

vimalptl · 2019-02-28T21:45:47Z

That's what I said. My apologies. I really like this project vue-form-generator. I was using this in my project and found a few things I felt was missing. I am going thought the code to see if I can integrate them. I also found instances where the date picker will not work properly with the environment we are on. Well I will look into that also. Let me first get familiar with the code. I was just trying to pull down the v3 code but kept getting v2.3.4. Thanks you.

…

On Wed, Feb 27, 2019 at 6:21 PM David Higgins ***@***.***> wrote: wtf? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#599 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADhoeExudeCylAecwDK4vHHWr7OK1RLlks5vRz0QgaJpZM4bVmJp> .

zoul0813 · 2019-02-28T22:03:43Z

Closing - this appears to be a mistaken PR

Lionel Bijaoui and others added 30 commits August 3, 2018 17:52

Streamlining of schema

fff0078

Streamlining of schema. Refactoring. Update of dependency.

3bd6587

Update of the test to work with the new schema

691ab4b

Update dependency

8dcf3a2

Trying to fix Travis

eb2ba1b

Trying to fix Travis 2

e4fb3a5

Trying to fix Travis 3

6993560

Trying to fix Travis 4

48cf6ba

Trying to fix Travis 5

3998391

Trying to fix Travis 6

dd866e0

Trying to fix Travis 7 (no pretest, no lint)

8fdda39

Trying to fix Travis 8 (no yarn in Travis)

e84ede2

Trying to fix Travis 8 (npm need to be at least 4.0.0 to work)

f2de7f7

Merge pull request #481 from lionel-bijaoui/lb_streamlined_schema

c0b65b5

Streamlining of schema

Rework on validation and events to allow for a more flexible structure

5594b32

Use an event bus for most events Breaking: validate is a promise since now all validation is asynchronous

Creation of dev entry to test multiple instances of vue-form-generator

c70a2b7

Better isolation of the event bus

2f1e6b7

Dev for grouping updated

0cb2d21

Better groups

2f83710

Fix some test

7ff9443

Update dep

Update tests

c416802

- Remove some skip - Fix some test

Merge pull request #484 from lionel-bijaoui/lb_better_groups

02055ec

Better groups and new validation mechanic

Custom label, help and hint

a7a1bd3

- Possibility to use scoped-slot to customise fully how label, help or hint are build - Little change to the structure to make it easy to do this - Heavy use of scoped-slot - Expose `field` object and `getValueFromOption` function

Custom errors

12434e3

- Possibility to use scoped-slot to customise fully how errors are build - Expose `errors` object, `field` object and `getValueFromOption` function

Make custom label, help, hint and errors work with groups

94be402

- Create a new dev project to test custom and project - Remove custom code from "full" dev project

Enhance "custom" dev project with better examples

05a1e8e

- Label with icon depending on field input type - Help with support for Markdown - Errors displayed in a table - Hint with icon and color

Add some tests

f51b83b

Fix test

44511f9

- Remove forgotten `only`

Fix codacy errors

1c061f2

Remove debug info

ac27bf3

Lionel Bijaoui and others added 26 commits October 16, 2018 14:53

formGroup now use the correct class name for error when looking for them

c865489

Fix code coverage

e15672b

- Code coverage is back ! - Update dependencies

Fix Coverall path to "lcov.info"

67f8ebd

Merge pull request #519 from lionel-bijaoui/lb_fix_class_error_group

04460af

formGroup now use the correct class name for error when looking for them

Fix submodule version

3b8abe6

Merge pull request #518 from lionel-bijaoui/lb_help_in_group

f7195e9

Add Help in `form-group`

Fix tests

e6fa363

Drop node 6 support as vue-cli don't support it

6f222ec

Improve code coverage score

46fd658

- Fix fieldUpload

Merge pull request #520 from lionel-bijaoui/lb_code_coverage_reactiva…

bd49a45

…tion Code coverage reactivation

Fix deep property path not working

e49a969

Merge pull request #529 from lionel-bijaoui/v3

21918ba

Fix deep property path not working

#501

7adcc11

#521

10840a8

#522

f21b73a

#509

96aea0c

Merge pull request #530 from lionel-bijaoui/lb_implement_501_509_521_522

55b5d9f

Implement #501 #509 #521 #522

Custom legend block for group

b694fae

- Possibility to use scoped-slot to customise fully how legend is build - Expose `group` and `groupLegend` in slot prop

Merge pull request #531 from lionel-bijaoui/lb_custom_legend

322fb57

Custom legend block for group

Update submodule dev

c611132

Clean useless folders

b603196

Single export

2b31d12

- No more core vs full since both are the same right now - Optionnal fields will be removed from it in future update

Bump version to 3.0.0-beta.7

449da34

- Update dependencies - Export dist files

Merge pull request #532 from lionel-bijaoui/lb_v3.0.0-beta.7

2b4ab0b

Release v3.0.0-beta.7

remove event listeners in abstractField for current context only

ffb839f

Merge pull request #546 from gapipro/v3

218baba

Big fix: v3 - Remove event listeners in abstractField for current context only

zoul0813 closed this Feb 28, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

V3 #599

V3 #599

Uh oh!

vimalptl commented Feb 27, 2019

Uh oh!

zoul0813 commented Feb 28, 2019

Uh oh!

vimalptl commented Feb 28, 2019 via email

Uh oh!

zoul0813 commented Feb 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

V3 #599

V3 #599

Uh oh!

Conversation

vimalptl commented Feb 27, 2019

Uh oh!

zoul0813 commented Feb 28, 2019

Uh oh!

vimalptl commented Feb 28, 2019 via email

Uh oh!

zoul0813 commented Feb 28, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants