Skip to content

feat: enable brackets rule #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 26, 2021
Merged

feat: enable brackets rule #2

merged 3 commits into from
Dec 26, 2021

Conversation

@k-miyake
Copy link
Contributor

@k-miyake k-miyake commented Dec 25, 2021 •
edited by naokie
Loading

@naokie このライブラリを使っている Vue ハンズオンのリポジトリ で丸かっこをチェックしたいニーズが出てきました。
ref. vuejs-jp/handson-vue3#85

そこで、このライブラリの元になっている textlint-rule-preset-JTF-style の 4.3.1.丸かっこ（） が有効になっていなかったので追加してみました。既存に影響が出ないようにデフォルトでは false にセットしています。

@k-miyake k-miyake added the enhancement New feature or request label Dec 25, 2021
@k-miyake k-miyake requested a review from naokie December 25, 2021 07:33
@k-miyake k-miyake self-assigned this Dec 25, 2021
@k-miyake k-miyake marked this pull request as draft December 25, 2021 07:35
@k-miyake k-miyake removed the request for review from naokie December 25, 2021 07:35
@k-miyake
Copy link
Contributor Author

k-miyake commented Dec 25, 2021

フォーマッターが当たってしまい、余計な差分が出てしまったので一旦戻します。

@k-miyake k-miyake marked this pull request as ready for review December 25, 2021 07:40
@k-miyake k-miyake requested a review from naokie December 25, 2021 07:40
@k-miyake
Copy link
Contributor Author

k-miyake commented Dec 25, 2021

追加したルールのみ差分が出るように修正しましたので、あらためてレビューをお願いします。

naokie
naokie approved these changes Dec 25, 2021
View reviewed changes
Copy link
Member

@naokie naokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM です 👍🏼

@k-miyake k-miyake merged commit 3a1a846 into main Dec 26, 2021
@k-miyake
Copy link
Contributor Author

k-miyake commented Dec 26, 2021

@naokie ありがとうございます。マージしました。

@naokie naokie deleted the enable-brackets branch December 30, 2021 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@naokie naokie naokie approved these changes

Assignees

@k-miyake k-miyake

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@k-miyake @naokie