Have simple JS object for configuration

[ifraixedes]

I am wondering if you don't think that's nicer to have a simple and usual JS object for the configurations rather than having to wrap the string in double quotes because that object is provided as it's to the Webpack define plugin, but we could provide pass the JSON representation of it before assigning to process.env

I had that modification in my project and it was easy to make, however I created the project when this template was for webpack v1 and last week I did the update and found that it's hard and tedious to synchronize changes if you have modifications in the template build folder, so I rolled back them to have the less changes as possible in order to have a simple upgrades in the future.

Thanks for considering.

[LinusBorg]

Can you specify what exactly you mean with "the configurations":

a simple and usual JS object for the configurations

It seems you are talking about environment variables(?), but that's not really clear to me.

[ifraixedes]

Sorry, my fault.

I'm talking about the environment variables which are in config folder, specified with the files ended with .env.js

[LinusBorg]

...and what does your propose change would look like? I don't really see how we would get around the need for quoting strings twice - or do you suggest to turn .env.js files into JSON files?

If so, that's not a good idea, as it would be very limiting.

[ifraixedes]

No, I don't suggest to turn them into JSON.

Those environment files are read in a few limited places, we only have to make a simple change in those.

I wanted to check if there is a preference to keep them as they are, because I was thinking that you prefer that people understand that those values are injected in the web application by the Webpack DefinePlugin, but I see that there aren't any such preferences, so if it's fine for you I'll try to send a PR in a couple of weeks with such update and it will be more clear what changes are needed.

[LinusBorg]

Sure!

[LinusBorg]

I'm, working on improving config with #1178