Skip to content

Conversation

@edison1105
Copy link
Member

No description provided.

@coderabbitai
Copy link

coderabbitai bot commented Oct 24, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/feat/defineVaporCustomElement

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Oct 24, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 84.8 kB 30 kB 26.5 kB
runtime-dom.global.prod.js 107 kB (+695 B) 40 kB (+229 B) 36 kB (+190 B)
vue.global.prod.js 165 kB (+695 B) 60.2 kB (+233 B) 53.6 kB (+185 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47.8 kB 18.7 kB 17.1 kB
createApp 56.6 kB 21.8 kB 19.9 kB
createApp + vaporInteropPlugin 89.5 kB (+229 B) 33.5 kB (+77 B) 30.3 kB (+96 B)
createVaporApp 33.4 kB (+244 B) 12.8 kB (+117 B) 11.7 kB (+110 B)
createSSRApp 60.9 kB 23.6 kB 21.5 kB
defineCustomElement 62.5 kB (+486 B) 23.6 kB (+141 B) 21.5 kB (+121 B)
overall 71.6 kB 27.2 kB 24.7 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 24, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@14017

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@14017

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@14017

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@14017

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@14017

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@14017

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@14017

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@14017

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@14017

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@14017

@vue/shared

npm i https://pkg.pr.new/@vue/shared@14017

vue

npm i https://pkg.pr.new/vue@14017

@vue/compat

npm i https://pkg.pr.new/@vue/compat@14017

commit: 8a298fa

@edison1105 edison1105 force-pushed the edison/feat/defineVaporCustomElement branch from a819eeb to e808152 Compare October 24, 2025 03:55
@netlify
Copy link

netlify bot commented Oct 29, 2025

Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name Link
🔨 Latest commit c423a43
🔍 Latest deploy log https://app.netlify.com/projects/vue-sfc-playground/deploys/690174ce6fb6fb0008aa81fc

@edison1105 edison1105 force-pushed the edison/feat/defineVaporCustomElement branch from c423a43 to 642e253 Compare October 29, 2025 02:09
@edison1105 edison1105 force-pushed the edison/feat/defineVaporCustomElement branch from 642e253 to 9b5e134 Compare October 29, 2025 02:15
defineSSRCustomElement can only be used with custom elements that have pre-rendered declarative shadow root
await assertInteraction('my-element-async')
})

test('work with Teleport (shadowRoot: false)', async () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defineSSRCustomElement can only be used with custom elements that have pre-rendered declarative shadow root. It requires shadowRoot: true.

@edison1105 edison1105 marked this pull request as ready for review October 29, 2025 09:48
@edison1105 edison1105 added ✨ feature request New feature or request version: minor scope: vapor related to vapor mode labels Oct 29, 2025
@edison1105 edison1105 moved this to Vapor in Next Minor Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: vapor related to vapor mode ✨ feature request New feature or request version: minor

Projects

Status: Vapor

Development

Successfully merging this pull request may close these issues.

2 participants