Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,6 @@ return function render(_ctx, _cache, $props, $setup, $data, $options) {
}"
`;

exports[`compiler: expression transform > expression with type 1`] = `
"const { openBlock: _openBlock, createElementBlock: _createElementBlock } = Vue

return function render(_ctx, _cache) {
return (_openBlock(), _createElementBlock("div", {
onClick: _ctx.handleClick
}, null, 8 /* PROPS */, ["onClick"]))
}"
`;

exports[`compiler: expression transform > should allow leak of var declarations in for loop 1`] = `
"const { openBlock: _openBlock, createElementBlock: _createElementBlock } = Vue

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -754,12 +754,4 @@ describe('compiler: expression transform', () => {
expect(code).toMatch(`_ctx.bar`)
})
})

test('expression with type', () => {
const { code } = compile(
`<div @click="(<number>handleClick as any)"></div>`,
)
expect(code).toMatch(`onClick: _ctx.handleClick`)
expect(code).toMatchSnapshot()
})
})
12 changes: 4 additions & 8 deletions packages/compiler-core/src/transforms/transformExpression.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import {
createSimpleExpression,
} from '../ast'
import {
TS_NODE_TYPES,
isInDestructureAssignment,
isInNewExpression,
isStaticProperty,
Expand Down Expand Up @@ -348,18 +347,15 @@ export function processExpression(
// an ExpressionNode has the `.children` property, it will be used instead of
// `.content`.
const children: CompoundExpressionNode['children'] = []
const isTSNode = TS_NODE_TYPES.includes(ast.type)
ids.sort((a, b) => a.start - b.start)
ids.forEach((id, i) => {
// range is offset by -1 due to the wrapping parens when parsed
const start = id.start - 1
const end = id.end - 1
const last = ids[i - 1]
if (!(isTSNode && i === 0)) {
const leadingText = rawExp.slice(last ? last.end - 1 : 0, start)
if (leadingText.length || id.prefix) {
children.push(leadingText + (id.prefix || ``))
}
const leadingText = rawExp.slice(last ? last.end - 1 : 0, start)
if (leadingText.length || id.prefix) {
children.push(leadingText + (id.prefix || ``))
}
const source = rawExp.slice(start, end)
children.push(
Expand All @@ -376,7 +372,7 @@ export function processExpression(
: ConstantTypes.NOT_CONSTANT,
),
)
if (i === ids.length - 1 && end < rawExp.length && !isTSNode) {
if (i === ids.length - 1 && end < rawExp.length) {
children.push(rawExp.slice(end))
}
})
Expand Down
Loading