Skip to content

refactor: introduce setAsyncRef on DynamicFragment for explicit async component ref assignment #14153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
Merged

refactor: introduce setAsyncRef on DynamicFragment for explicit async component ref assignment #14153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/runtime-vapor/src/apiDefineAsyncComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,8 +197,7 @@ function createInnerComp(
if ($transition) setTransitionHooks(instance, $transition)

// set ref
// @ts-expect-error
frag && frag.setRef && frag.setRef(instance)
frag && frag.setAsyncRef && frag.setAsyncRef(instance)

return instance
}
13 changes: 6 additions & 7 deletions packages/runtime-vapor/src/apiTemplateRef.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,12 @@ export function setRef(
return
}

const isVaporComp = isVaporComponent(el)
if (isVaporComp && isAsyncWrapper(el as VaporComponentInstance)) {
const i = el as VaporComponentInstance
const frag = i.block as DynamicFragment
// async component not resolved yet
if (!i.type.__asyncResolved) {
frag.setRef = i => setRef(instance, i, ref, oldRef, refFor)
if (isVaporComponent(el) && isAsyncWrapper(el)) {
const frag = el.block as DynamicFragment
// async component not resolved yet, register ref setter
// it will be called when the async component is resolved
if (!el.type.__asyncResolved) {
frag.setAsyncRef = i => setRef(instance, i, ref, oldRef, refFor)
return
}

Expand Down
3 changes: 3 additions & 0 deletions packages/runtime-vapor/src/fragment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ export class DynamicFragment extends VaporFragment {
// fallthrough attrs
attrs?: Record<string, any>

// set ref for async wrapper
setAsyncRef?: (instance: VaporComponentInstance) => void

// get the kept-alive scope when used in keep-alive
getScope?: (key: any) => EffectScope | undefined

Expand Down
Loading