Skip to content

Conversation

@edison1105
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings December 4, 2025 08:58
@coderabbitai
Copy link

coderabbitai bot commented Dec 4, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch edison/fix/vaporComponentInVdomSlot

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 85.2 kB 29.9 kB 26.4 kB
runtime-dom.global.prod.js 108 kB (+2 B) 40.5 kB 36.5 kB (+19 B)
vue.global.prod.js 166 kB (+2 B) 60.5 kB 53.9 kB (-18 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.2 kB (+2 B) 18.8 kB (+1 B) 17.2 kB (+3 B)
createApp 57.2 kB (+2 B) 22 kB (+2 B) 20.1 kB (+15 B)
createApp + vaporInteropPlugin 95.9 kB (+22 B) 35.4 kB (+13 B) 31.9 kB (+19 B)
createVaporApp 40.9 kB 15.2 kB 13.8 kB
createSSRApp 61.6 kB (+2 B) 23.8 kB (+1 B) 21.7 kB (+3 B)
defineCustomElement 63.3 kB (+2 B) 23.8 kB (+2 B) 21.7 kB (-3 B)
overall 71.9 kB (+2 B) 27.2 kB (+1 B) 24.8 kB (+4 B)

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 4, 2025

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@14167

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@14167

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@14167

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@14167

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@14167

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@14167

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@14167

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@14167

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@14167

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@14167

@vue/shared

npm i https://pkg.pr.new/@vue/shared@14167

vue

npm i https://pkg.pr.new/vue@14167

@vue/compat

npm i https://pkg.pr.new/@vue/compat@14167

commit: c4ba60c

Copilot finished reviewing on behalf of edison1105 December 4, 2025 09:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes injection context propagation by enabling slotted Vapor child components to properly inject values provided by their VDOM parent components. The fix ensures the parent component's context is active during slot mounting.

  • Added parentComponent parameter to the slot method in the Vapor interop interface
  • Set the current instance to the parent component during vapor slot mounting to establish proper injection context
  • Added comprehensive test coverage for the VDOM parent to Vapor child injection scenario

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/runtime-vapor/src/vdomInterop.ts Sets current instance to parentComponent during slot mounting to enable proper injection context for slotted vapor children
packages/runtime-core/src/apiCreateApp.ts Updated VaporInteropInterface.slot signature to include parentComponent parameter
packages/runtime-core/src/renderer.ts Passed parentComponent argument when calling the slot method during VaporSlot processing
packages/runtime-vapor/tests/apiInject.spec.ts Added test case verifying injection works from VDOM parent to slotted Vapor child, plus cleanup setup

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@edison1105 edison1105 added the scope: vapor related to vapor mode label Dec 4, 2025
@edison1105 edison1105 merged commit 2f0676f into minor Dec 4, 2025
23 checks passed
@edison1105 edison1105 deleted the edison/fix/vaporComponentInVdomSlot branch December 4, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: vapor related to vapor mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants